This repository was archived by the owner on Sep 2, 2023. It is now read-only.
Qingwei/disable range selector in purchase #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling b4b617f on qingweibinary:qingwei/disable_range_selector_in_purchase into * on binary-com:master*. |
| const lastNewTicksEpoch = getLast(newTicks).epoch; | ||
| const oldestExistingTickEpoch = existingTicks[0].epoch; | ||
| const lastExistingTickEpoch = getLastTick(existingTicks).epoch; | ||
| const lastExistingTickEpoch = getLast(existingTicks).epoch; |
There was a problem hiding this comment.
BTW getLast turns out is an overkill 💃
because [][0] is undefined anyways, it is not an error 👯
There was a problem hiding this comment.
it at least serve as a shorthand of
superUglyAndLongVariableName[superUglyAndLongVariableName.length - 1]
qingweibinary
deleted the
qingwei/disable_range_selector_in_purchase
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.