This repository was archived by the owner on Sep 2, 2023. It is now read-only.
Nuru/android release #510
Merged
Nuru/android release #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gulpfile.js
Outdated
| unalignedApk: './platforms/android/build/outputs/apk/android-release-unaligned.apk', | ||
| alignedApk: './platforms/android/build/outputs/apk/android-release-aligned.apk', | ||
| zipAligned: '/Users/nuru/Library/Android/sdk/build-tools/23.0.3/zipalign', // Note the path to the zipalign on your pc | ||
| keyPassword: '****', // make sure you don't push the correct password here to github. Edit password before running task |
There was a problem hiding this comment.
Very easy to push the password by mistake - can you change this to read the password from a .gitignore-listed external file or user input instead?
There was a problem hiding this comment.
It is virtually guaranteed to happen once out of 10 times. ;)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Attached contained few changes that should automate our android release for your perusal.