This repository was archived by the owner on Sep 2, 2023. It is now read-only.
Qingwei/debug perf #514
Closed
Qingwei/debug perf #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What does that mean? :) |
|
@borisyankov typo in |
|
Hmmm... |
|
|
||
| shouldComponentUpdate(nextProps) { | ||
| const hasNotEq = Object.keys(this.props).some(k => { | ||
| if (JSON.stringify(this.props[k]) !== JSON.stringify(nextProps[k])) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@borisyankov
Profiling on macbook I am using does not show significant difference, although number of render is reduce a whole lot. Time taken and profile chart both are close
each render spent more than 80% of CPU time in binary, maybe that's a better place to optimize
Note: This is for discussion, do not merge unless you're sure ;)