This repository was archived by the owner on Sep 2, 2023. It is now read-only.
Update electron builder #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| "coveralls": "^2.11.12", | ||
| "css-loader": "^0.24.0", | ||
| "electron": "^1.3.5", | ||
| "electron-builder": "^6.4.0", |
There was a problem hiding this comment.
Look in build/package.json
We'll have these dependencies there.
There was a problem hiding this comment.
Couldn't find any . I can see gulp-atom-electron though. Are you referring to that ?
There was a problem hiding this comment.
All dependencies that are required for building, especially electron, are in build, so a developer does not need to do big updates all the tipe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Attached contained few changes that should update our electron build for your perusal.