Skip to content
This repository was archived by the owner on Sep 2, 2023. It is now read-only.

Conversation

nazaninreihani
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.786% when pulling 38072b4 on nazaninreihani:fix-translate into 54a1f57 on binary-com:dev.

@arnabk arnabk merged commit e38fd7e into regentmarkets-repo-archive:dev Jun 13, 2017
@arnabk
Copy link
Contributor

arnabk commented Jun 16, 2017

@nazaninreihani I figured out that we are not supposed to change the translation files under _constants/po/*.js

If we need new translation, we have to checkout translation branch and add all our requirements into *.po and *.pot files. Once you add those translation requirement in those files, weblate system will translate them and we have to run sh fetch-translation.sh command in dev branch to generate the new .json and .js file out of those translated files.

Please do not worry about the changes you submitted in those .js files. They will get overidden by the command mentioned above. For now, could you please add those empty translation strings in those .po files and then submit the PR to translation branch? I will take care of all other tasks from there.

@nazaninreihani
Copy link
Contributor Author

nazaninreihani commented Jun 17, 2017

@arnabk sure I will do this

@nazaninreihani nazaninreihani deleted the fix-translate branch June 23, 2017 10:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants