Skip to content

Conversation

rupato-deriv
Copy link
Contributor

@rupato-deriv rupato-deriv commented Sep 22, 2023

Added a fix for the Trackjs issue which was because of there was no mobile check and the Blockly used to load first and was not getting the reference resulting null as there is no trashcan on the mobile view.

image

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 22, 2023 9:04am

@rupato-deriv rupato-deriv changed the title Rupato/fix: for trackJS issue Rupato/fix: for trackJS SVGGroup_ issue Sep 22, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
13.9% 13.9% Duplication

@rupato-deriv rupato-deriv changed the title Rupato/fix: for trackJS SVGGroup_ issue Rupato/BOT-741/fix: for trackJS SVGGroup_ issue Sep 22, 2023
@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10247](https://github.com/binary-com/deriv-app/pull/10247)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rupato-deriv-rupato-fix-trackjs-svggr-9f215a.binary.sx?qa_server=red.binaryws.com&app_id=31894
    - **Original**: https://deriv-app-git-fork-rupato-deriv-rupato-fix-trackjs-svggr-9f215a.binary.sx
- **App ID**: `31894`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 75
🟧 Best practices 83
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-rupato-deriv-rupato-fix-trackjs-svggr-9f215a.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 10.866% (+0.001%) from 10.865% when pulling 7285c4b on rupato-deriv:Rupato/fix--TrackJS-svgGroup-null into 7c9661a on binary-com:master.

@jim-deriv jim-deriv merged commit 0e1ddb1 into deriv-com:master Sep 27, 2023
vinu-deriv pushed a commit that referenced this pull request Oct 10, 2023
vinu-deriv pushed a commit that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants