Skip to content

Kate / WEBREL-1501 / While clicking on duration field (Ticks) we are getting error #10631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2023
Merged

Kate / WEBREL-1501 / While clicking on duration field (Ticks) we are getting error #10631

merged 2 commits into from
Oct 12, 2023

Conversation

kate-deriv
Copy link
Contributor

@kate-deriv kate-deriv commented Oct 12, 2023 •
edited
Loading

Changes:

  • Add missing field
  • Add test case

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Oct 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 12, 2023 11:46am

@boring-cyborg boring-cyborg bot added the Shared label Oct 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/10631](https://github.com/binary-com/deriv-app/pull/10631)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-webrel-1501fixdurationerror.binary.sx?qa_server=red.binaryws.com&app_id=32466
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-webrel-1501fixdurationerror.binary.sx
- **App ID**: `32466`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-webrel-1501fixdurationerror.binary.sx/

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vinu-deriv vinu-deriv merged commit 17a390b into deriv-com:master Oct 12, 2023
vinu-deriv pushed a commit that referenced this pull request Oct 17, 2023
@kate-deriv @vinu-deriv
Kate / WEBREL-1501 / While clicking on duration field (Ticks) we are …
12657e5 
…getting error (#10631)

* fix: add missing field

* fix: add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinu-deriv vinu-deriv vinu-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

+1 more reviewer

@maryia-deriv maryia-deriv maryia-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Shared

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kate-deriv @vinu-deriv @maryia-deriv