[DTRA] Ahmad/FEQ-853/Feat launch modal #11196

ahmadtaimoor-deriv · 2023-11-06T03:38:21Z

Changes:

A modal is added in the app when the new smartchart (flutter chart) is loaded. The modal advertise and notify users about the new charts loaded.
The modal will be shown to the logged in user.

Screenshots:

Web:

Mobile:

vercel · 2023-11-06T03:38:25Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Nov 23, 2023 8:56am

github-actions · 2023-11-06T03:46:59Z

A production App ID was automatically generated for this PR. (log)

PR: [DTRA] Ahmad/FEQ-853/Feat launch modal #11196
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-ahmadtaimoor-deriv-featlaunchmodal.binary.sx?qa_server=red.derivws.com&app_id=31580
- Original: https://deriv-app-git-fork-ahmadtaimoor-deriv-featlaunchmodal.binary.sx
App ID: 31580

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/11196](https://github.com/binary-com/deriv-app/pull/11196)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ahmadtaimoor-deriv-featlaunchmodal.binary.sx?qa_server=red.derivws.com&app_id=31580
    - **Original**: https://deriv-app-git-fork-ahmadtaimoor-deriv-featlaunchmodal.binary.sx
- **App ID**: `31580`

github-actions · 2023-11-06T03:47:17Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	15
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟧 PWA	80

Lighthouse ran with https://deriv-app-git-fork-ahmadtaimoor-deriv-featlaunchmodal.binary.sx/

coveralls · 2023-11-06T03:51:32Z

coverage: 28.369% (+0.2%) from 28.185%
when pulling 859bc1d on ahmadtaimoor-deriv:feat_launch_modal
into 532d47b on binary-com:master.

packages/trader/src/Modules/SmartChartBeta/Components/LaunchModal/launch-modal.tsx

packages/trader/src/Modules/Trading/Containers/smart-chart-switcher.jsx

packages/trader/src/Modules/SmartChartBeta/Components/LaunchModal/launch-modal.tsx

packages/core/src/Services/logout.js

...ges/trader/src/Modules/SmartChartBeta/Components/LaunchModal/__tests__/launch-modal.spec.tsx

packages/trader/src/Modules/SmartChartBeta/Components/LaunchModal/launch-modal.scss

packages/trader/src/Modules/SmartChartBeta/Components/LaunchModal/launch-modal.tsx

packages/trader/src/Modules/SmartChartBeta/Components/LaunchModal/launch-modal.scss

packages/trader/src/Modules/Trading/Containers/smart-chart-switcher.jsx

packages/trader/src/Modules/SmartChartBeta/Components/LaunchModal/launch-modal.tsx

...ges/trader/src/Modules/SmartChartBeta/Components/LaunchModal/__tests__/launch-modal.spec.tsx

github-actions · 2023-11-23T07:53:34Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-11-23T07:53:40Z

🚀 Smoke test run (1) passed successfully!

github-actions · 2023-11-23T07:54:23Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

packages/trader/src/Modules/Trading/Containers/trade.jsx

github-actions · 2023-11-23T08:09:04Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-11-23T08:11:09Z

🚀 Smoke test run (1) passed successfully!

github-actions · 2023-11-23T08:12:12Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-11-23T08:21:38Z

🚀 Smoke test run (2) passed successfully!

github-actions · 2023-11-23T08:21:39Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-11-23T08:22:26Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

sonarqubecloud · 2023-11-23T08:24:15Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
17.5% Duplication

github-actions · 2023-11-23T08:37:26Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-11-23T08:37:26Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-11-23T08:57:26Z

🚀 Smoke test run (1) passed successfully!

github-actions · 2023-11-23T08:58:33Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

This reverts commit 531c4d9.

ahmadtaimoor-deriv added 7 commits November 2, 2023 14:34

feat: launch modal added with png

81eab16

feat: fixes

1faafa5

feat: adding modal for beta only

aadca9a

feat: remove unused added prop

dd2b6a0

feat: add new portal element

181e08f

fix: changing scss

c2ee69a

translations: fix

8533bf1

ahmadtaimoor-deriv requested review from ali-hosseini-deriv, maryia-deriv and matin-deriv as code owners November 6, 2023 03:38

boring-cyborg bot added Core Trader labels Nov 6, 2023

ahmadtaimoor-deriv deployed to Preview November 6, 2023 03:38 — with GitHub Actions Active

ahmadtaimoor-deriv deployed to Preview November 6, 2023 03:38 — with GitHub Actions View deployment

fix: code smell

1308832

ahmadtaimoor-deriv deployed to Preview November 6, 2023 03:46 — with GitHub Actions Active

ahmadtaimoor-deriv deployed to Preview November 6, 2023 03:46 — with GitHub Actions View deployment

henry-deriv reviewed Nov 6, 2023

View reviewed changes

packages/trader/src/Modules/SmartChartBeta/Components/LaunchModal/launch-modal.tsx Outdated Show resolved Hide resolved

henry-deriv reviewed Nov 6, 2023

View reviewed changes

packages/trader/src/Modules/Trading/Containers/smart-chart-switcher.jsx Outdated Show resolved Hide resolved

henry-deriv reviewed Nov 6, 2023

View reviewed changes

packages/trader/src/Modules/SmartChartBeta/Components/LaunchModal/launch-modal.tsx Outdated Show resolved Hide resolved

akmal-deriv reviewed Nov 6, 2023

View reviewed changes

ahmadtaimoor-deriv marked this pull request as draft November 7, 2023 07:09

maryia-deriv suggested changes Nov 8, 2023

View reviewed changes

fix: review fixes with new design

0d5fd1a

boring-cyborg bot added the Components label Nov 15, 2023

fix: removing react fc

1c2b8d4

ahmadtaimoor-deriv temporarily deployed to Preview November 23, 2023 07:53 — with GitHub Actions Inactive

ahmadtaimoor-deriv deployed to Preview November 23, 2023 07:53 — with GitHub Actions View deployment

maryia-deriv approved these changes Nov 23, 2023

View reviewed changes

maryia-deriv suggested changes Nov 23, 2023

View reviewed changes

packages/trader/src/Modules/Trading/Containers/trade.jsx Show resolved Hide resolved

ahmadtaimoor-deriv added 2 commits November 23, 2023 16:17

fix: merge master

c83c0ee

fix: conflict

859bc1d

ahmadtaimoor-deriv temporarily deployed to Preview November 23, 2023 08:21 — with GitHub Actions Inactive

ahmadtaimoor-deriv deployed to Preview November 23, 2023 08:21 — with GitHub Actions View deployment

ahmadtaimoor-deriv requested a review from maryia-deriv November 23, 2023 08:22

akmal-deriv approved these changes Nov 23, 2023

View reviewed changes

maryia-deriv approved these changes Nov 23, 2023

View reviewed changes

balakrishna-deriv approved these changes Nov 23, 2023

View reviewed changes

balakrishna-deriv merged commit 531c4d9 into deriv-com:master Dec 1, 2023

balakrishna-deriv added a commit to balakrishna-deriv/deriv-app that referenced this pull request Dec 6, 2023

Revert "[DTRA] Ahmad/FEQ-853/Feat launch modal (deriv-com#11196)"

88bbff5

This reverts commit 531c4d9.

hamza-deriv pushed a commit that referenced this pull request Dec 6, 2023

Revert "[DTRA] Ahmad/FEQ-853/Feat launch modal (#11196)" (#12057)

fbf2462

This reverts commit 531c4d9.

hamza-deriv pushed a commit that referenced this pull request Dec 6, 2023

Revert "[DTRA] Ahmad/FEQ-853/Feat launch modal (#11196)" (#12057)

d768cf7

This reverts commit 531c4d9.

[DTRA] Ahmad/FEQ-853/Feat launch modal #11196

[DTRA] Ahmad/FEQ-853/Feat launch modal #11196

Uh oh!

Conversation

ahmadtaimoor-deriv commented Nov 6, 2023

Changes:

Screenshots:

Uh oh!

vercel bot commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 23, 2023

Uh oh!

github-actions bot commented Nov 23, 2023

Uh oh!

github-actions bot commented Nov 23, 2023

Uh oh!

Uh oh!

github-actions bot commented Nov 23, 2023

Uh oh!

github-actions bot commented Nov 23, 2023

Uh oh!

github-actions bot commented Nov 23, 2023

Uh oh!

github-actions bot commented Nov 23, 2023

Uh oh!

github-actions bot commented Nov 23, 2023

Uh oh!

github-actions bot commented Nov 23, 2023

Uh oh!

sonarqubecloud bot commented Nov 23, 2023

Uh oh!

github-actions bot commented Nov 23, 2023

Uh oh!

github-actions bot commented Nov 23, 2023

Uh oh!

github-actions bot commented Nov 23, 2023

Uh oh!

github-actions bot commented Nov 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

vercel bot commented Nov 6, 2023 •

edited

Loading

github-actions bot commented Nov 6, 2023 •

edited

Loading

github-actions bot commented Nov 6, 2023 •

edited

Loading

coveralls commented Nov 6, 2023 •

edited

Loading