Skip to content

Conversation

thisyahlen-deriv
Copy link
Contributor

Changes:

  1. Update description content for demo dxtrade success modal

Screenshots:

Screenshot 2023-11-30 at 11 11 41 AM

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 30, 2023 3:30am

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11892](https://github.com/binary-com/deriv-app/pull/11892)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-2667-47ba85.binary.sx?qa_server=red.derivws.com&app_id=32930
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-2667-47ba85.binary.sx
- **App ID**: `32930`

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-2667-47ba85.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 29.022% (-0.002%) from 29.024%
when pulling 8c1d07e on thisyahlen-deriv:thisyahlen/WALL-2667/update_description_content_for_derivx
into 36d1841 on binary-com:master.

@mahdiyeh-deriv mahdiyeh-deriv merged commit 67cb907 into deriv-com:master Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants