Skip to content

Conversation

farhan-nurzi-deriv
Copy link
Contributor

@farhan-nurzi-deriv farhan-nurzi-deriv commented Dec 27, 2023

Changes:

Add check in translations script before uploading to crowdin

Screenshots:

image

Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com>
Copy link

vercel bot commented Dec 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 27, 2023 9:16am

Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
3.1% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented Dec 27, 2023

Coverage Status

coverage: 33.827% (-0.001%) from 33.828%
when pulling f0a14b9 on farhan-nurzi-deriv:farhan/fix-translations
into 6b07c16 on binary-com:master.

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12552](https://github.com/binary-com/deriv-app/pull/12552)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-fix-translations.binary.sx?qa_server=red.derivws.com&app_id=30346
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-fix-translations.binary.sx
- **App ID**: `30346`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-fix-translations.binary.sx/

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

Generating Lighthouse report...

@nijil-deriv nijil-deriv merged commit 042c1c9 into deriv-com:master Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants