Skip to content

Conversation

lubega-deriv
Copy link
Contributor

Changes:

  • Fix colour of transactions amount to match design

Screenshots:

Screenshot 2024-01-02 at 6 17 13 PM

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 2, 2024 11:02am

@lubega-deriv lubega-deriv changed the title fix: transactions amount colour [WALL] Lubega / WALL-3173 / Fix: Transactions amount colour Jan 2, 2024
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 2, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12658](https://github.com/binary-com/deriv-app/pull/12658)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-3173-transactions-a-241262.binary.sx?qa_server=red.derivws.com&app_id=31585
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-3173-transactions-a-241262.binary.sx
- **App ID**: `31585`

Copy link
Contributor

github-actions bot commented Jan 2, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-3173-transactions-a-241262.binary.sx/

@coveralls
Copy link

coveralls commented Jan 2, 2024

Coverage Status

coverage: 34.117% (-0.07%) from 34.183%
when pulling b6abcf2 on lubega-deriv:WALL-3173/transactions-amount-colour-fix
into 35b8923 on binary-com:master.

Copy link
Contributor

github-actions bot commented Jan 2, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Generating Lighthouse report...

@nijil-deriv nijil-deriv merged commit d6cd5af into deriv-com:master Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants