Skip to content

Conversation

sergei-deriv
Copy link
Contributor

Changes:

Renamed components:

  • packages/tradershub/src/features/cfd/screens/MT5TradeScreen/MT5TradeScreen.tsx
  • packages/tradershub/src/features/cfd/screens/MT5TradeScreen/MT5TradeDetailsItem/MT5TradeDetailsItem.tsx
  • packages/tradershub/src/features/cfd/screens/MT5TradeScreen/MT5TradeLink/MT5TradeLink.tsx

Card:

https://app.clickup.com/t/20696747/TRAH-2625

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 11, 2024 0:23am

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
3.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12912](https://github.com/binary-com/deriv-app/pull/12912)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sergei-deriv-sergei-trah-2625rename-m-058d02.binary.sx?qa_server=red.derivws.com&app_id=24064
    - **Original**: https://deriv-app-git-fork-sergei-deriv-sergei-trah-2625rename-m-058d02.binary.sx
- **App ID**: `24064`

@coveralls
Copy link

Coverage Status

coverage: 34.579% (+0.006%) from 34.573%
when pulling fb7a39d on sergei-deriv:sergei/trah-2625/rename-mt5tradescreen
into badbde3 on binary-com:master.

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-trah-2625rename-m-058d02.binary.sx/

@thisyahlen-deriv thisyahlen-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Jan 12, 2024
@mahdiyeh-deriv mahdiyeh-deriv merged commit 431d167 into deriv-com:master Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trader's Hub PR's that are created to the new trader's hub package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants