Akmal / feat: standartize contract cards across all trade types #13935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akmal-deriv
requested review from
ali-hosseini-deriv,
mahdiyeh-deriv,
maryia-deriv and
matin-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-akmal-deriv-f-standartize-contract-cards.binary.sx/ |
farhan-nurzi-deriv
previously approved these changes
Mar 1, 2024
ahmadtaimoor-deriv
approved these changes
Mar 1, 2024
maryia-deriv
previously approved these changes
Mar 1, 2024
kate-deriv
reviewed
Mar 1, 2024
kate-deriv
approved these changes
Mar 1, 2024
akmal-deriv
dismissed stale reviews from maryia-deriv and farhan-nurzi-deriv
via
6c79525
farhan-nurzi-deriv
previously approved these changes
Mar 6, 2024
henry-deriv
approved these changes
Mar 6, 2024
kate-deriv
reviewed
Mar 7, 2024
maryia-deriv
reviewed
Mar 7, 2024
maryia-deriv
suggested changes
Mar 7, 2024
maryia-deriv
previously approved these changes
Mar 8, 2024
|
maryia-deriv
approved these changes
Mar 11, 2024
Dhruv-deriv
pushed a commit
to Dhruv-deriv/deriv-app
that referenced
this pull request
Mar 20, 2024
…v-com#13935) * feat: standartize contract cards across all trade types * fix: type error * fix: test case * fix: responsive indicators * fix: remove vanilla arrow from desktop * feat: add indicative colors and arrows to all trade types * chore: change px to rem * fix: incorrect label for closed contracts * chore: update test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This feature focuses on standardizing contract cards to ensure consistency and coherence across all trade types within the platform. Previously, contract cards might have varied in layout, design, or displayed information based on the specific trade type, potentially leading to confusion or inconsistency in the user interface. With this update, contract cards are unified in terms of design elements, layout structure, and displayed information, regardless of the trade type selected. By standardizing contract cards, users can expect a cohesive and familiar experience when interacting with different trade options, facilitating easier navigation and comprehension. This enhancement contributes to a more polished and user-friendly interface, improving overall usability and user satisfaction.