Skip to content

Conversation

sergei-deriv
Copy link
Contributor

Changes:

Add Trustpilot api key to 2 more github actions

@sergei-deriv sergei-deriv requested a review from a user June 3, 2024 13:36
@sergei-deriv sergei-deriv requested a review from matin-deriv as a code owner June 3, 2024 13:36
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jun 4, 2024 7:06am

Copy link
Contributor

github-actions bot commented Jun 3, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15463](https://github.com/binary-com/deriv-app/pull/15463)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sergei-deriv-sergei-add-trustpilot-api-key-2.binary.sx?qa_server=red.derivws.com&app_id=24068
    - **Original**: https://deriv-app-git-fork-sergei-deriv-sergei-add-trustpilot-api-key-2.binary.sx
- **App ID**: `24068`

Copy link
Contributor

github-actions bot commented Jun 3, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-add-trustpilot-api-key-2.binary.sx/

@coveralls
Copy link

coveralls commented Jun 3, 2024

Coverage Status

Changes unknown
when pulling a193413 on sergei-deriv:sergei/add-trustpilot-api-key-2
into ** on binary-com:master**.

ghost
ghost previously approved these changes Jun 3, 2024
Copy link
Contributor

@ali-hosseini-deriv ali-hosseini-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please pass TRUSTPILOT_API_KEY to the analyze action that being called in analyze workflow in below path:
.github/workflows/analyze.yml

@sergei-deriv
Copy link
Contributor Author

please pass TRUSTPILOT_API_KEY to the analyze action that being called in analyze workflow in below path: .github/workflows/analyze.yml

@ali-hosseini-deriv Thank you. Done

Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

@habib-deriv habib-deriv merged commit b2eef6e into deriv-com:master Jun 4, 2024
shahzaib-deriv pushed a commit that referenced this pull request Jun 4, 2024
* feat: add trustpilot api key to 2 more github actions

* feat: add key to the analyze workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants