Skip to content

Conversation

aizad-deriv
Copy link
Contributor

Changes:

  • added unit test for SentEmailContent

Screenshots:

image

@aizad-deriv aizad-deriv self-assigned this Aug 15, 2024
@aizad-deriv aizad-deriv requested a review from a user August 15, 2024 06:38
Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 15, 2024 8:32am

Copy link
Contributor

github-actions bot commented Aug 15, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16504](https://github.com/binary-com/deriv-app/pull/16504)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-2882test-case-c647bd.binary.sx?qa_server=red.derivws.com&app_id=38674
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-2882test-case-c647bd.binary.sx
- **App ID**: `38674`

Copy link
Contributor

github-actions bot commented Aug 15, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 34
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-wall-2882test-case-c647bd.binary.sx/

@coveralls
Copy link

coveralls commented Aug 15, 2024

Coverage Status

coverage: 46.06% (+0.05%) from 46.006%
when pulling b436eb3 on aizad-deriv:aizad/WALL-2882/test-case-SentEmailContent
into df7f2a8 on binary-com:master.

ghost
ghost previously approved these changes Aug 15, 2024
Copy link

@nijil-deriv nijil-deriv merged commit ce0d456 into deriv-com:master Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants