hamid/wall-21/crypto-withdraw-form #9372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hamid-deriv
changed the base branch from
master
to
feature/wallets_with_traders_hub
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-hamid-deriv-hamid-wall-21crypto-withdrawal.binary.sx/ |
heorhi-deriv
approved these changes
Jul 19, 2023
packages/appstore/src/components/wallet-withdrawal/wallet-withdrawal.scss
Outdated
Show resolved
Hide resolved
packages/cashier/src/components/percentage-selector/percentage-selector.scss
Outdated
Show resolved
Hide resolved
packages/cashier/src/components/recent-transaction/recent-transaction.scss
Outdated
Show resolved
Hide resolved
packages/cashier/src/components/recent-transaction/recent-transaction.tsx
Outdated
Show resolved
Hide resolved
packages/cashier/src/pages/withdrawal/crypto-withdraw-form/crypto-withdraw-form.scss
Outdated
Show resolved
Hide resolved
packages/cashier/src/pages/withdrawal/crypto-withdraw-form/crypto-withdraw-form.tsx
Outdated
Show resolved
Hide resolved
heorhi-deriv
approved these changes
Jul 19, 2023
nijil-deriv
approved these changes
Jul 19, 2023
thisyahlen-deriv
approved these changes
Jul 20, 2023
aum-deriv
reviewed
Jul 20, 2023
| const url_params = useMemo(() => new URLSearchParams(url_query_string), [url_query_string]); | ||
| const action_param = url_params.get('action'); | ||
| const loginid = url_params.get('loginid'); | ||
|
|
There was a problem hiding this comment.
@farzin-deriv as we are using this logic for redirecting the user in many places, can we make a hook to reuse the logic? Maybe in the future, this hook can replace the redirect.jsx file :thinking
There was a problem hiding this comment.
@aum-deriv Probably yes 👍🏻 But <Redirect /> has been used in many places, First we need to figure out the use cases and then make the change.
heorhi-deriv
approved these changes
Jul 20, 2023
mahdiyeh-deriv
approved these changes
Jul 25, 2023
heorhi-deriv
approved these changes
Aug 2, 2023
…l-21/crypto-withdrawal
hamid-deriv
requested review from
ali-hosseini-deriv,
farrah-deriv and
matin-deriv
as code owners
nijil-deriv
changed the base branch from
feature/wallets_with_traders_hub
to
feature/wallets_with_traders_hub_2
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.