chore: ts migration for onfido and routes #9675
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-utkarsha-deriv-utkarsha-ts-migration-3db53a.binary.sx/ |
| list_item_desktop_open: JSX.Element; | ||
| list_item_sent_by_you: JSX.Element; | ||
| subtitle: JSX.Element; | ||
| title: JSX.Element; |
There was a problem hiding this comment.
is there any reason for writing JSX.Element for all? could this be a string?
There was a problem hiding this comment.
The file uses component which returns a JSX Element
| DeactivateAccount, | ||
| LanguageSettings, | ||
| } from 'Sections'; | ||
| } from '../Sections'; |
There was a problem hiding this comment.
why is this changed to relative path?
There was a problem hiding this comment.
It was giving errors in console but with relative path issue was resolved.
|
|
||
| // Order matters | ||
| const initRoutesConfig = ({ is_appstore }) => [ | ||
| const initRoutesConfig = (is_appstore: boolean): TRouteConfig[] => [ |
There was a problem hiding this comment.
will this work correctly at places initRoutesConfig is invoked? here its now a boolean parameter, but i think an object will be passed as arguments to this function. right?
| ]; | ||
|
|
||
| let routesConfig; | ||
| let routesConfig: undefined | TRouteConfig[]; |
There was a problem hiding this comment.
can we write it in reverse?
TRouteConfig[] | undefined 🙂
2 participants
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.