Skip to content

Conversation

shafin-deriv
Copy link
Contributor

Changes:

Investigating the issue of the transaction being frozen on quickly stopping the bot (if the contract is still open but we stopped the bot). For the solution, we are registering to the onMessage listener and listening for proposal open contracts (POC). If there is any POC that is triggered from the Bot project then wait for it first close then update the contract in UI so the transaction panel doesn't get stuck.

In the useEffect we are unsubscribing from the listener if the user moves away from the Bot project and again listens for it when they land on the Bot project. If it's subscribed once we are disabling it to subscribe again using a flag.

@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 14, 2023 3:57am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9969](https://github.com/binary-com/deriv-app/pull/9969)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shafin-deriv-shafin-bot-702chore-tran-4f0ebe.binary.sx?qa_server=red.binaryws.com&app_id=38789
    - **Original**: https://deriv-app-git-fork-shafin-deriv-shafin-bot-702chore-tran-4f0ebe.binary.sx
- **App ID**: `38789`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-shafin-deriv-shafin-bot-702chore-tran-4f0ebe.binary.sx/

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants