Skip to content

Conversation

arcofdescent
Copy link
Contributor

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have the requirement to provide the field, we need a test case for it. And we need documentation.

@torsten-deriv
Copy link
Contributor

Can you please overhaul the POD. Look here https://metacpan.org/pod/Experian::IDAuth.

  1. find the format errors. First thing that pops up in my eyes is the URL that is not a link. Such things.
  2. the page looks impressive but it actually contains very little information about the module. Most of the stuff is just blah blah. All the sections CHANGES FROM 1.X, BUGS and SUPPORT are superfluous. Nobody in the company cares about all these bug trackers etc. So, remove that crap.
  3. try to look at the POD tuning out your knowledge of the module and try to understand what it does. If you don't understand, tune in your knowledge and improve the documentation. Repeat these steps until the documentation is complete and comprehensive.

@arcofdescent
Copy link
Contributor Author

Yeah, ok. Moving this back to development. But I needed this release as we need the PEP check. Anyway, I will improve the POD.

@torsten-deriv
Copy link
Contributor

One more thing. I think the module has a UTF8 problem. The way it generates the XML request looks very suspicious.

I won't force you to fix that because the module works for us. But a note in the documentation would be good.

torsten-deriv added a commit that referenced this pull request Nov 3, 2015
@torsten-deriv torsten-deriv merged commit 0ea9d1b into deriv-com:master Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants