Path generation performance improvements #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MawiraIke
commented
Jan 13, 2022
| path-info | ||
| ;; if the previous item is an artificial vector, lets append to the path info but take the first item | ||
| ;; in the vector as the path. (Explained in `mapping` above) | ||
| (and (map? (get-second-last-object-from-current-history)) |
There was a problem hiding this comment.
Removed this double call.
MawiraIke
commented
Jan 13, 2022
| (mapping? (get-second-last-object-from-current-history) parent-object)) | ||
| (conj (or path-info []) (first parent-object)) | ||
| ;; the current object is an item within the parent object | ||
| (some? (build-path-segment parent-object object)) |
There was a problem hiding this comment.
Removed this double call. Takes long to fetch index of items in very large maps so limit to one call.
|
@darwin @MawiraIke if possible, we would love to see this merged soon because it delivers needed improvements for re-frame-10x |
|
@mike-thompson-day8 thanks for bringing this up. I forgot to get back to it. Will look into it over the weekend. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #65