Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliant to 1.9.0-alpha11 spec for (ns (:require)) #33

Closed
fonghou opened this issue Aug 25, 2016 · 1 comment
Closed

Compliant to 1.9.0-alpha11 spec for (ns (:require)) #33

fonghou opened this issue Aug 25, 2016 · 1 comment

Comments

@fonghou
Copy link

fonghou commented Aug 25, 2016

Hi,

1.9.0-alpha11 includes spec for (ns ...) macro, which only allows keywords, not symbols for ns clauses. Would you include the fix in the next release?

Good news is only three (ns .. (:require)) in these files to be changed.

dirac/lib/nrepl_tunnel.clj
dirac/agent/config.clj
dirac/nrepl/config.clj

Tested OK with a local copy. Btw, figwheel-0.5.5 requires 1.9.0 spec now, and wish people can use them together.

Thanks!

@fonghou fonghou changed the title Compliant o 1.9.0-alpha11 spec for (ns (:require)) Compliant to 1.9.0-alpha11 spec for (ns (:require)) Aug 25, 2016
@danielcompton
Copy link
Collaborator

This is fixed in master with d673fbb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants