Console filter buttons act weird #4

mtruyens · 2016-02-07T20:12:28Z

The filter buttons on the console do not work in the same way as they do in the regular Developer Tools console. For example, when I try to leave out the "Debug" messages, clicking on the Debug filter button with Command (on my Mac) held down sometimes works, and sometimes does not.

The same for the other buttons...

…rs with setWaitForDebuggerOnStart. (patchset #4 id:60001 of https://codereview.chromium.org/1679133002/ ) Reason for revert: Breaks http/tests/inspector-enabled/dedicated-workers-list.html. BUG=586342 Original issue's description: > [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart. > > In addition encapsulated InspectorInstrumentation calls in WorkerInspectorProxy and make it responsible for "pause on start" decisions. > > BUG=none TBR=pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/1692813002 Cr-Commit-Position: refs/heads/master@{#375070}

8893c96 DevTools Timeline: polish RAIL 7d6ac13 Indexed DB: Remove string version plumbing 86fc13c Revert of DevTools: add input event instrumentation test (patchset #2 id:40001 of https://codereview.chromium.org/1704723002/ ) 317b69e [DevTools] Use setTextAndTitle() to show tooltips in service workers view. 944f79f DevTools: expose major oilpan events in Timeline 8d8b8d3 DevTools: add input event instrumentation test b21deec [DevTools] Add sourceMap support for blackboxing d0f431d DevTools: capture javascript stack trace for asynchronous image requests. 9388936 DevTools: get rid of open types in the protocol generator. db0e036 Devtools: Prevent == $0 tip from causing changes to layout 971e746 [DevTools] Fix rendering options on small sizes 6ccd457 Devtools: Collapse drawer when console is open in both panel & drawer 25e8b57 DevTools: Add samling heap profiler support to BE and protocol b0acda5 DevTools: Fix closure compilation after -r375297 7325f0d DevTools: move protocol-related generators into inspector subfolder. 29360f6 DevTools: [Console] fix viewport stick-to-bottom behavior 464cfc6 [DevTools] Allow emulating "screen" media in addition to "print". 1714c32 Revert of [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart. (patchset #4 id:60001 of https://codereview.chromium.org/1679133002/ ) 31c568e Devtools Animations: Remove cached left value when resizing 78c4dd4 [DevTools] Do not enable touch emulation when inspect mode is already engaged. 5bf7edd [DevTools] Align media queries inspector with quick width presets strip. 6b48a2e Revert of DevTools: [Console] wrap long strings in console (patchset #1 id:1 of https://codereview.chromium.org/1681013002/ ) 726e6ef [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart. 5315df4 DevTools: [Console] speedup array autocompletion 0eda8b1 DevTools: bring search results counter to the left c592274 DevTools: Fix search causing OOM in CPU profile view on large profiles. 6b7b196 Devtools: Don't clear custom user agent on double click 778934e DevTools: Make timeline memory pane resizable with its header. dd95126 Filter input events on Timeline based on id of tracing target 13eff76 DevTools: better distribution of JS frames colors on flamechart. 5e27c13 DevTools: highlight frame when hovered in the Source panel navigator. dcf75c2 DevTools: increase width of "Search across all files" field cfdf433 [DevTools] Do not reset page scale on changing zoom. c96df75 DevTools: [Console] wrap long strings in console 8bf1937 DevTools: Fix network events positions on the network flamechart. 6b382b4 Devtools: Add metrics for drawer views being shown e3e27a9 [DevTools] Show values between 1Mb/s and 10Mb/s with one decimal point. e02af11 [DevTools] Do not clear manually entered height value in Device Mode. 83b6d1e [DevTools] Rename "accelerometer" to "device orientation", validate values. 5bd29fa DevTools: do not use platform/ to load injected scripts into inspector/v8. c1d97db update obsolete code.google.com documentation links d1f13d8 DevTools: Fix timeline memory pane checkbox alignment 9e6a579 [DevTools] Remove main -> emulation dependency. ab29e36 Devtools: Use Event.deepPath as a function if available. 3b52d7d Wrap UI strings for a table in the Security panel in UIString calls. git-subtree-dir: resources/unpacked/devtools git-subtree-split: 8893c96

…ttps://codereview.chromium.org/1637813002/ ) Reason for revert: Breaks devtools. Landed without devtools review. Original issue's description: > Change Event.deepPath to a method > > In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. > See the discussion here: WICG/webcomponents#361 > Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget > See the spec change here: WICG/webcomponents@ed93413 > BUG=531990 > > Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 > Cr-Commit-Position: refs/heads/master@{#372596} > > Committed: https://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d > Cr-Commit-Position: refs/heads/master@{#376103} TBR=samli@chromium.org,hayato@chromium.org,kochi@chromium.org,kojii@chromium.org,yuzus@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=531990 Review URL: https://codereview.chromium.org/1710893003 Cr-Commit-Position: refs/heads/master@{#376223}

2975ecf [DevTools] Add touch to sensors view. 6aada89 Timeline: extract and rename TracingModelLoader into a file of its own 2d4d494 DevTools: extract TimelineProfileTree into a file for better reuse 94e222e DevTools: [CSSP] do not wrap computed properties. 32c096c DevTools: Tweak timeline group headers drawing 8c6c1b4 [DevTools] Replace (un)blackboxURL methods with (un)blackboxUISourceCode 336beef DevTools: report resources as loaded upon failed request from workers. 21927a0 DevTools: [Console] do not replace '\t' control character b753ee4 [DevTools] Restore showViewportSizeOnResize. 1e5a8f6 [DevTools] Per debugger model state storage in BlackboxManager abd1fba Timeline: make flamechart groups collapsible b128f30 [DevTools] Disable JavaScript checkbox does not work. 880d35f DevTools: [Console] display control characters in console commands 6c90ade DevTools: [SASS] implement SASSProcessor.InsertProperties operation 03cdbcd Devtools: Allow filtered list widget keyboard navigation to wrap around 9edfc28 DevTools: [SASS] implement SASSProcessor.RemoveProperty operation 782faca Devtools: Switch JS execution context to match inspected node 33698a9 DevTools: [SASS] implement SASSProcessor.ToggleProperty operation a6d7338 [DevTools] Added Linkify.linkifyStackTraceTopFrame method 70ca603 DevTools: [SASS] add WI.SASSProcessor and first "setText" operation 058aca3 DevTools: [SASS] get rid of WI.ASTSourceMap.rebaseForCSSDiff/rebaseForSASSDiff a08075b [DevTools] Add "show throttling" to device mode instead of "configure network". 5a074fb Indexed DB: Rename "int version" to "version" 4c5344b DevTools: [CSS] fix CSS style formatter 75fb6f6 DevTools: remove oldText from SourceEdit 3a85dd8 [DevTools] Fix minor bugs in frontend. 2c24ca0 DevTools: [CSSP] make "goto source" icon crisp ff9eff8 DevTools: Extract SegmentedRange from TimelineIRModel to utilities.js cab214a Reland of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (patchset #1 id:1 of https://codereview.chromium.org/1723663005/ ) b0611c8 Revert of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (patchset #5 id:80001 of https://codereview.chromium.org/1711083002/ ) 69e96fb DevTools: migrate remote debugging protocol generators to jinja2. 22e4373 [DevTools] Make max-width media queries symmetric. 33be141 DevTools: remove FileSystem API inspection from experiments, point users to the extension. ecf45f5 [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. 4a73f2e [DevTools] Add device type to custom device presets. 9ae3c2c [DevTools] Restore show rulers functionality. 97f87ca [DevTools] Don't load sourcemap for blackboxed scripts a58cff0 [DevTools] Add sourceURL deprecation message for scripts 9bbd93f DevTools: [SASS] re-implement SASSSupport.Rule.insertProperties de2e154 DevTools: improve SCSS parser to correctly handle variable expansions ba5dd8b DevTools: [SASS] correctly add sass module 4af0766 DevTools: Make JSFrames occupy all the space between samples. ae10e88 DevTools: rename WI.SASSLiveSourceMap into WI.ASTSourceMap. c8d03ed Revert of DevTools: improve SCSS parser to correctly handle variable expansions (patchset #1 id:1 of https://codereview.chromium.org/1713783003/ ) 7a2d28f DevTools: improve SCSS parser to correctly handle variable expansions d41f526 DevTools: teach WI.CSSParser to parse style ranges 4c9b383 DevTools: introduce WI.ASTService instead of WI.SASSWorkspaceAdapter 55f115b DevTools: [Console] wrap long strings in console 4184a0d Revert: [DevTools] Removed support deprecated (//@|/*@) source(URL|MappingURL)= 2cc00e1 Animation: Add optional specified animation id e7ca2a5 DevTools: Make FlameChart._measureText use Map for caching. 8e8a476 DevTools: Reduce unattributed size in timeline tree view c8f0ddb [DevTools] Rework device scale factor and user agent type UI. dc9e2b3 DevTools: [CSS] Add CSS.setMultipleStyleTexts command to CSS domain 6cfae37 Timeline FlameChart: clean up a handful of redundant member fields be5c866 [DevTools] Blackboxing in LiveLocations is supported in Linkifier 44eeeb2 [DevTools] Replace let with var c296234 DevTools: Prepare for CPU profiler code events turn from Instant to Meta. f2eb763 [DevTools] Support CommandLineAPI in snippets c8ceef9 Revert of Change Event.deepPath to a method (patchset #4 id:60001 of https://codereview.chromium.org/1637813002/ ) a19117d DevTools: add input event instrumentation test 4e76f53 [DevTools] Add workaround for closure compiler for Event.prototype.deepPath 6b7cfe8 DevTools: remove bottom-up flame charts 3487e2c Change Event.deepPath to a method git-subtree-dir: resources/unpacked/devtools git-subtree-split: 2975ecf

… of its own (patchset #4 id:60001 of https://codereview.chromium.org/1739193003/ ) Reason for revert: Possible cause behind failure in webkit-tests on WebKit Mac10.11 and WebKit Mac10.11 (retina). Original issue's description: > Timeline: extract and rename TracingModelLoader into a file of its own > > This just extracts TimelineLoader with the aim of later refactoring > it to untangle timeline lifecycle events from TimelineModel. > > Committed: https://crrev.com/b994e8b0a8af48aca6aa2182b5e8157b4873c0e9 > Cr-Commit-Position: refs/heads/master@{#378109} TBR=alph@chromium.org,caseq@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review URL: https://codereview.chromium.org/1752453002 Cr-Commit-Position: refs/heads/master@{#378291}

… of its own (patchset #1 id:1 of https://codereview.chromium.org/1752453002/ ) Reason for revert: Reverting of revert, it doesn't look to me this was the culprit in layout test failures. Original issue's description: > Revert of Timeline: extract and rename TracingModelLoader into a file of its own (patchset #4 id:60001 of https://codereview.chromium.org/1739193003/ ) > > Reason for revert: > Possible cause behind failure in webkit-tests on WebKit Mac10.11 and WebKit Mac10.11 (retina). > > Original issue's description: > > Timeline: extract and rename TracingModelLoader into a file of its own > > > > This just extracts TimelineLoader with the aim of later refactoring > > it to untangle timeline lifecycle events from TimelineModel. > > > > Committed: https://crrev.com/b994e8b0a8af48aca6aa2182b5e8157b4873c0e9 > > Cr-Commit-Position: refs/heads/master@{#378109} > > TBR=alph@chromium.org,caseq@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > > Committed: https://crrev.com/c4ffa58b1a2c1eb0484dc21b68632e96c070652c > Cr-Commit-Position: refs/heads/master@{#378291} TBR=alph@chromium.org,nektar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1754713002 Cr-Commit-Position: refs/heads/master@{#378464}

ec7586b DevTools: speedup tracing model event phases check. 13f9b8d DevTools: Remove vendor-prefixed css rule audit. f81a8eb Remove V8RecrusionScope, cleanup call sites. 1730f5c DevTools: [CSS] fix CSS pretty-print mapping. 6aa06db Timeline: moar collapsible groups polish on Flame Chart c9a1145 Devtools: Fix space key in Styles pane editing d466a1c Devtools: Command menu item scoring a4ae446 DevTools: Initial implementation of line-level CPU profile. ac71c29 DevTools: [Formatter] unify JavaScriptFormattedContentBuilder and CSSFormattedContentBuilder 364df9a Timeline: fix collapsible groups rendering in dark theme 7107128 DevTools: Do not invoke CPU throttling on worker targets. ab4dda0 DevTools: Make the colors for the same URL be the same for all recording. 7d03994 DevTools: [CSS] rename WI.CSSStyleModel into WI.CSSModel a80d023 Timeline: fix nested group visibility computation 34d3722 Timeline: fix exception when clicking on drawer padding with collapsible groups enabled 445c765 Timeline: show RAIL phase strip unconditionally on actual records being present ae734b5 DevTools: add readme to project root. b4cc6f0 Timeline: move eventStackFrame from TimelineTreeView to TimelineProfileTree f46adb2 Timeline: extract profile tree aggregator into a model-level class 5a5a874 DevTools: Support line markers in UISourceCode and Code Mirror 4d40c3f [DevTools] Removed unused hidden protocol method: getStepInPositions 7730a99 DevTools: fix FlameChart compile error due to mid-air collision with compiler roll b7f8409 [DevTools] Strip "get" and "set" prefixes when describing functions 3dfedf8 [DevTools] Enable user select / text copy in ServiceWorkersView. 7b580d6 [DevTools] Show viewport size on resize by default, disable in device mode. 5a90646 Devtools: truncate long strings in tooltip 89991cb Devtools: resolve expressions in minified scripts with sourcemaps e400a18 Timeline: add support for multi-level headers in flame chart e62a2c1 Updated devices with updates from github repository. d1ce20d DevTools: [Fonts] show if rendered font was loaded from internet 62b51eb [DevTools] Fix event listener sidebar c6cfba2 DevTools: generate string16-based handlers for v8_inspector. 38f07de [DevTools] Roll closure compiler to ToT version d43ba4a [DevTools] Regression: newly added throttling option is not selectable. 4625713 Remove primary load waterfall experiment from DevTools. 54b0caa DevTools: Add scroll bar to the JSON view. 02cd465 Timeline: extract TimelineController from TimelineModel f35a8ae [DevTools] Fix more frontend compiler errors bb56e56 DevTools: remove support for node annotations from Paint Profiler's front-end b4a19e7 [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart. 7222211 [DevTools] Fix compile errors before closure compiler roll 0c06c27 Handle emulated device scale factor and original device scale factor properly in use-zoom-for-dsf mode. 6d9eb43 [DevTools] Fix compiler errors in bindings module 33d4868 DevTools: mapify internal field in WI.CompilerScriptMapping 249d324 [DevTools] Prepare UI module for closure compiler roll 0f2ab46 Devtools: add Security panel to user metrics 1766d85 Devtools: resolve parameters names via sourcemaps fba03bb [DevTools] Remove Array.from method from utilities.js f7fc52c DevTools: promisify WI.SourceMap.load 8e9359b Devtools: Do not greedily collapse URLs 3732b03 DevTools: make AsyncCallFrame clickable in callstack sidebar. bf8e685 Devtools: Fix rendering of async callframes in CallStackSidebarPane eea93dc Devtools: Add a command menu b530136 Devtools: Use Runtime.StackTrace instead of Debugger.StackTrace in asyncs 15bef42 Timeline: quit using Progress, introduce TimelineLifecycleDelegate c3959d8 DevTools: [CSS] rename WI.CSSStyleModel.MatchedStyleResult into WI.CSSMatchedStyles 086e9bf DevTools: [CSS] cleanup WI.CSSStyleModel 6b37253 Timeline: fix timeline saving and make the test actually test it 9e786e0 Devtools: [Experiment] parse variables in scopes and sourcemap them a409066 DevTools: [CSS] split CSSStyleModel into multiple files ae3656e DevTools: [CSS] prepare CSSStyleModel to be split into multiple files d426b74 DevTools: generalize rebaseline for all of the CSSStyleModel types. e44f293 Timeline: merge TimelineModelLoadFromFileDelegate into TimelineLoader 47bf952 Devtools: remove async scopes 542adc7 Timeline: fix timeline saving so we don't write after close 6fe9de9 Remove webkit-background-composite 6224336 [DevTools] Add script content hash to scriptParsed protocol event dcd8017 Reland of Timeline: extract and rename TracingModelLoader into a file of its own (patchset #1 id:1 of https://codereview.chromium.org/1752453002/ ) 73af080 DevTools: [CSS] move matching selectors from WI.CSSStyleRule to WI.MatchedStyleResult ed69af4 Revert of Timeline: extract and rename TracingModelLoader into a file of its own (patchset #4 id:60001 of https://codereview.chromium.org/1739193003/ ) 8ae9005 Timeline: merge TimelineModelLoadFromFileDelegate into TimelineLoader 329a59a Devtools: Add guide line for selected/hovered node in DOM tree git-subtree-dir: resources/unpacked/devtools git-subtree-split: ec7586b

id:60001 of https://codereview.chromium.org/1922303004/ ) Reason for revert: Breaks focus from Cmd+P Original issue's description: > DevTools: fix focus restoration from command menu > > BUG=604427 > > Committed: https://crrev.com/0a0b2833b563519dbade8923c6fde6c75c728ea8 > Cr-Commit-Position: refs/heads/master@{#391057} TBR=dgozman@chromium.org,luoe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=604427 Review-Url: https://codereview.chromium.org/1944993002 Cr-Commit-Position: refs/heads/master@{#391356}

4150aff DevTools: [SASS] start parsing CSS with SCSS parser 51b0ebb DevTools: [SASS] parse SCSS rules and their selectors. 292d4f9 Revert of DevTools: fix focus restoration from command menu (patchset #4 id:60001 of https://codereview.chromium.org/1922303004/ ) d79bed2 DevTools: fix styles in rendering pane d21c547 DevTools: properly update close icon in search field dab74b9 DevTools: Reorder timeline checkboxes. 05809f9 DevTools: mute the node highlight & hide devtools while taking screenshots. a3b8435 Security panel: add listeners only to the added target. f4f510c [DevTools] 20px default top inset gutter to avoid Ruler overlap in emulation mode f2b80ce Fix issue causing no cookies to be shown in the Resources > Cookies panel. 78782d0 Revert of Fixed DevTools event-listener breakpoints for PointerEvents. (patchset #3 id:40001 of https://codereview.chromium.org/1915623002/ ) 0af8110 Timeline: use RAIL phases to color input events 8939357 DevTools: fix user agent custom behavior 9f84e26 DevTools: fix focus restoration from command menu 68642cb [Devtools] isTrusted in CustomEvents shown twice in console 4a00752 DevTools: brush up command menu looks, render badges. 81dfcdf DevTools: fix visual regressions in full text search d329629 [Devtools] Fix to XMLView in Network Preview panel broken 42f1d67 DevTools: Move network pane on timeline out of experiment 0e0cd5c Fixed DevTools event-listener breakpoints for PointerEvents. 3a717ab [DevTools] Add base JS Proxy support git-subtree-dir: resources/unpacked/devtools git-subtree-split: 4150aff

…1 of https://codereview.chromium.org/2094903002/ ) Reason for revert: The test is very flaky. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnetwork%2Fwebsocket%2Finitiator.html Original issue's description: > [Devtools] Fixed websocket initiators > > BUG=457811 > R=dgozman > > Committed: https://crrev.com/b08177119dcdbf407492ca84065a6cff32fd78b0 > Cr-Commit-Position: refs/heads/master@{#402313} TBR=dgozman@chromium.org,allada@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457811 Review-Url: https://codereview.chromium.org/2102003002 Cr-Commit-Position: refs/heads/master@{#402423}

2b946eb [Devtools] Fixed websocket initiators 03159a0 DevTools: Fix a bug where user agent shadow dom elements were inspectable by recursively checking for shadow dom 67b5471 DevTools: fix deepActiveElement and focus on Dialog when document blurs 08001ae CT in DevTools: use "Source" rather than "Origin". 6e4adf6 [DevTools] Move Console to v8 inspector. 68fbc73 DevTools: Center vertically around a highlighted element cf57c6f [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier. 671e397 [DevTools] Move collectionEntries to internalProperties in protocol 52c463c Addition of Certificate Transparency details to Security panel of DevTools 06b9e50 Revert of [Devtools] Fixed websocket initiators (patchset #4 id:100001 of https://codereview.chromium.org/2094903002/ ) 480926e Revert of Add autocomplete values for CSS contain (patchset #1 id:1 of https://codereview.chromium.org/2085523003/ ) c4fea64 DevTools: eliminate race condition in WI.StylesSourceMapping. f117125 [Devtools] Fixed websocket initiators 1d09555 DevTools: Close all sources command 2bf8793 DevTools: Don't lowercase SVG and other XML-like elements 7f40f91 DevTools: Add autocomplete values for CSS contain 31710e7 Show the size of images in a picture element Also fix a small bug where srcsets without a resolution wouldn't get a preview 5a4cb9d DevTools: add CSS completion for contain property. 5d3f372 DevTools: render markers as circles on the main timeline. git-subtree-dir: resources/unpacked/devtools git-subtree-split: 2b946eb

…the drawer views. (patchset #4 id:60001 of https://codereview.chromium.org/2137763002/ ) Reason for revert: Possible compile failure on Linux ChromiumOS GN Original issue's description: > DevTools: automatically populate 'More tools' submenu with the drawer views. > > NOTRY=true > NOPRESUBMIT=true > > Committed: https://crrev.com/51a628c40b3f8e25e35bb45f94f9417ff8b7fc37 > Cr-Commit-Position: refs/heads/master@{#404838} TBR=dgozman@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2142303002 Cr-Commit-Position: refs/heads/master@{#404845}

…the drawer views. (patchset #4 id:60001 of https://codereview.chromium.org/2137763002/ ) Reason for revert: Possible compile failure on Linux ChromiumOS GN Original issue's description: > DevTools: automatically populate 'More tools' submenu with the drawer views. > > NOTRY=true > NOPRESUBMIT=true > > Committed: https://crrev.com/51a628c40b3f8e25e35bb45f94f9417ff8b7fc37 > Cr-Commit-Position: refs/heads/master@{#404838} TBR=dgozman@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/07d2063bc853aebc485346bbe118f33d8b54d597 Review-Url: https://codereview.chromium.org/2142303002 Cr-Original-Commit-Position: refs/heads/master@{#404845} Cr-Commit-Position: refs/heads/master@{#404848}

ba10beb DevTools: [SSP] render selectors effectively e1f4c5a DevTools: preserve computed properties expansion on Computed Style re-rendering b7f33c1 DevTools: fix compilation for the VBoxes with toolbar items. b924c0b Timeline: rearrange trace completion logic for better extensibility cad9b9b [DevTools] Replace SetScriptSourceError with ExceptionDetails in protocol 203ff82 DevTools: kill WI.SourcesView._showFile method 77dce3d [DevTools] Fix line and column in CallstackSidebarPane for async frames e9563c8 DevTools: rename SourceFrame.onTextEditorContentLoaded into onTextEditorContentSet e25e6a4 [DevTools] Make most fields of ExceptionDetails non-optional. e3e89c0 [DevTools] Move Timestamp to Runtime, measure it in milliseconds. fa23987 DevTools: WI.SourceCodeDiff should not depend on UISourceCode 7043980 [DevTools] Report console API calls through Runtime. d3fea98 [DevTools] Add callFrame to CPUProfileNode & SamplingHeapProfileNode 68abc16 [DevTools] Fix compilation after r405625. ced91b6 The WebInspector.sendOverProtocol method provides an easy mechanism to test and debug protocol commands. It's intended for developer debugging only. c90d667 [DevTools] Support for the inspector target type 06690b1 [DevTools] Remove CallUID from CPUProfileNode 38cacec DevTools: reuse computedstylesmodel in the elements sidebar base class. 913b1f4 [DevTools] Remove Console.messagesCleared event. d56fea1 [Devtools] Fixed minor regression with network log view padding 4668ad4 Revert of [Devtools] Improved URL parser for console (patchset #6 id:100001 of https://codereview.chromium.org/2125143002/ ) fd30c84 DevTools: Add color swatches to the Sources panel when editing style sheets. d1ae919 [DevTools] Fix native function console output c0efb9e [DevTools] Fix window object init on chrome://* pages b3f8d1d [DevTools] Replace the target type with capabilities 63326d4 DevTools: remove the ComputedStyles -> Styles pane dependency. 4061e0f Timeline: re-expose the total size of layout tree in details 780e500 DevTools: Move Spectrum from elements/ to components/ so that it can be used in both Sources and Elements. b1d7a4c DevTools: Added styling to checkboxes so that a focus state is displayed when tabbing through the checkboxes (for keyboard accessibility). 4e4c0be DevTools: remove panel-based clipboard events dispatching. 23db92f Fix uneven padding of network filters in the dev tools. Also makes the filter bar thinner. 0c99e59 DevTools: [LiveSASS] property enabling/disabling should not add spaces 8015295 DevTools: move functionality away from ElementsPanel for better DOM tree control reuse. f71174a [DevTools] Always send a copy of worker message through the page. 887cc95 [DevTools] Set skip_in_browser=true for synthethic keyboard events. 24e6291 DevTools: Sort execution contexts in nested frames 52cf2dc [DevTools] Remove functionDetails from protocol.json 5968266 [DevTools] make Runtime.CallFrame 0-based 21cc3d9 DevTools: remove ElementsTreeElement.updateSelection. e02009f DevTools: automatically populate 'More tools' submenu with the drawer views. 83d68a9 Revert of DevTools: automatically populate 'More tools' submenu with the drawer views. (patchset #4 id:60001 of https://codereview.chromium.org/2137763002/ ) 12fa1da Revert of DevTools: automatically populate 'More tools' submenu with the drawer views. (patchset #4 id:60001 of https://codereview.chromium.org/2137763002/ ) 6654cde DevTools: remove BaseToolbarPaneWidget. 19847b0 DevTools: automatically populate 'More tools' submenu with the drawer views. d280a56 [DevTools] Better heuristic for detecting object literals. 996eda5 Use output_all_resource_defines=false in most grd files. 300d534 [Devtools] Improved URL parser for console c466e98 [DevTools] Remove [V8] from InspectorInstrumentation. git-subtree-dir: resources/unpacked/devtools git-subtree-split: ba10beb

…hset #4 id:80001 of https://codereview.chromium.org/1986053004/ ) Reason for revert: [DevTools] Entering a HEX value into color picker and changing opacity results in an 8-digit HEX, currently seen as invalid. This should reland once 8-digit hex (#rrggbbaa) is a fully supported value for colors (once #76362 lands). Original issue's description: > Devtools Color: Basic support for #RRGGBBAA and #RGBA > > BUG=611687 > > Committed: https://crrev.com/97c7757e7ae143f63e5d7281d1a9837338b12562 > Cr-Commit-Position: refs/heads/master@{#395801} TBR=dgozman@chromium.org,lushnikov@chromium.org,noel@chromium.org,pfeldman@chromium.org,samli@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=630808 Review-Url: https://codereview.chromium.org/2186773002 Cr-Commit-Position: refs/heads/master@{#408153}

469ec16 Fix the common typo "snaphot" (should be "snapshot") 4b3578b [DevTools] Add "Disable JavaScript" into command menu 77f67a7 DevTools: measure should not destroy elements hierarchy. 2d2748b [DevTools] Show stack for console.warn messages b85a644 DevTools: simplify instance access to provided views. 4e2e5f6 DevTools: differentiate between singleton and factory extension classes. 06e4b99 DevTools: Show more details on orphan heap snapshot nodes. 0f8d89e DevTools: Keep timeline counters graph colors independent of dark theme. cfd315e DevTools: track extension instances, allow external instance resolution over runtime global object. e7bcc30 DevTools: do not switch to the sources panel when breakpoints are added. 8a9f382 DevTools: remove release mode from runtime. ef35b33 [DevTools] Track URL through the target 294dc0b [Devtools] Added Copy All as cURL to network log f28d247 [Devtools] Fix closure compiler ffe28ae DevTools: Route timeline context menu save/load actions through module extensions. a900e55 DevTools: fix formatting of continue statement 71df6ca Remove unused parameters to TextPrompt._loadCompletions callback 13815ee Revert of Devtools Color: Basic support for #RRGGBBAA and #RGBA (patchset #4 id:80001 of https://codereview.chromium.org/1986053004/ ) 52de359 DevTools: Optimize source color picker to analyze changed lines 25b6742 DevTools: implement proxy server for hosted mode f24ed9e [DevTools] Remove V8InspectorSession::backtraceObjectGroup. 2b6cc0f [DevTools] Fix function property preview in ObjectPropertySection f048011 Add ARIA panel to accessibility sidebar pane. git-subtree-dir: resources/unpacked/devtools git-subtree-split: 469ec16

see 24a209c

…t (patchset #4 id:60001 of https://codereview.chromium.org/2510883002/ ) Reason for revert: This introduced a color picker bug crbug.com/667739. To land, we need to fix the regression. Original issue's description: > DevTools: all swatches should have a default focused element > > Color swatches correctly respond to 'Enter' and 'Esc' because Spectrum calls > focus() whenever it loads. Bezier and shadow editors did not. This CL makes > bezier and shadow editors set a default focused element. SwatchPopoverHelper now > calls focus() after showing a view, instead of requiring each swatch-popover > implementation call focus. > > One peculiarity with color swatches is they may hide and show themselves after > loading a palette. To keep focus on the popover, focus restoring logic was added > to the SwatchPopoverHelper whenever hiding an old popover. > > BUG=665801 > > Committed: https://crrev.com/0384ce04d25ba97446b20e7ca2d423cec10c2ffd > Cr-Commit-Position: refs/heads/master@{#433382} TBR=dgozman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=665801 Review-Url: https://codereview.chromium.org/2527503002 Cr-Commit-Position: refs/heads/master@{#434060}

c415264 DevTools: all swatches get default focused element (reland with fix) b0f6833 [DevTools] Turn links into spans to prevent default behavior. c429003 DevTools: Prevent autocompletion for empty input in ClassesPaneWidget fe72c28 DevTools: expect length/size hints in descriptions with parenthesis b729888 DevTools: fix exception when setting a breakpoint in sourcemap source bc9a725 [DevTools] Remove preventFollow and special checks for links throughout frontend. 1daa027 [Devtools] Fix hover issue with darktheme in network c2a32c5 Revert of DevTools: all swatches should have a default focused element (patchset #4 id:60001 of https://codereview.chromium.org/2510883002/ ) d46cf38 [DevTools] Remove HandlerRegistry. b05d63c DevTools: [Persistence] properly copy breakpoints to filesystem during reload 03a1714 [DevTools] Refactor Linkifier to unify link processing. git-subtree-dir: resources/unpacked/devtools git-subtree-split: c415264

… of datagrid (patchset #4 id:100001 of https://codereview.chromium.org/2540543002/ ) Reason for revert: Broke timeline tree view. BUG=671487 Original issue's description: > [Devtools] Moved flatten children to children nodes instead of datagrid > > This patch moves the flattenNodeList() and renames it flattenChildren() to > be more appropriate. It is also moves it to the nodes instead of the > DataGrid. > > R=dgozman > BUG=None > > Committed: https://crrev.com/9d0774bc242a8126f10c9be7922549336162ed88 > Cr-Commit-Position: refs/heads/master@{#434901} TBR=dgozman@chromium.org,allada@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=None Review-Url: https://codereview.chromium.org/2554753004 Cr-Commit-Position: refs/heads/master@{#436770}

48cfc73 DevTools: [Persistence] validate persistence binding. 8983dc4 DevTools: support pretty-print of async/await 0bb8f9c [DevTools] ElementsBreadcrumbs Perf Improvements & Cleanup 485edbd DevTools: migrate last usages of samllIcons.png to UI.Icon b219cbd DevTools: move the GC button into the memory panel. 4e91f3e DevTools: fix exception in anchor icon decoration 2151098 [DevTools] clean console on navigation as early as possible e6909c9 DevTools: Disallow console.log statements with eslint 9a055de DevTools: fix private field usage violation discovered after the compiler roll. 7b79df5 Timeline: fix a bunch of references to out-of-file privates 36a2506 [DevTools] Fix Cookie Sort 5aea9cb DevTools: roll closure compiler to 20161201. a3668d7 Allow temporary file system for incognito DevTools. f6e5e03 DevTools: [Search] fix search results text 11a0cd3 DevTools: [Search] do not search inside binary files. e3304e3 DevTools: sort completions by prototype. BUG=672615 3556c6a DevTools: Add more Mac shortcuts into CodeMirrorTextEditor 13c5c38 DevTools: Add support for installing node and running eslint over devtools. 71a0e8b DevTools: copy the selected color by clicking the color picker's swatch 3f4bfb4 devtools: Make it possible to retrieve all cookies 726288e [Devtools] Fixed dark theme scrollbars consistency in settings bcf1f24 DevTools: Add eslint rules 8d4dcd6 DevTools: Console: More accurate autocomplete after a bracket 30de111 [Devtools] Upgrade acorn services to use ECMAScript7 4754f55 DevTools: Use TextPrompt for FilterBar instead of input element 11f7c43 DevTools: fix presubmit hooks for windows 8c19927 Revert of [DevTools] Remove methods on Common.Event. (patchset #2 id:20001 of https://codereview.chromium.org/2553043003/ ) eb4037c [DevTools] clean breakpoints and decorations onUISourceCodeContentChanged dea9302 [DevTools] proper cleanup BlackboxManager on targetRemoved 65279da [DevTools] Fix null tooltip errors 92349ca DevTools: [Persistence] show filesystem file instead of network b19febb DevTools: Sources: Allow Shift+PageUp select text a9185a4 DevTools: Sources: Evaluate selected text should be Ctrl+Shift+E a4b4140 DevTools: allow array previews to show static array getters 902adea [DevTools] Remove methods on Common.Event. ec0ee79 DevTools: Fix SuggestBox not showing without a maximum height a253fbe Revert of [Devtools] Moved flatten children to children nodes instead of datagrid (patchset #4 id:100001 of https://codereview.chromium.org/2540543002/ ) 0f8327a DevTools: Sources: Right clicking in a gutter always gets line number 2cf28d6 DevTools: [SSP] make rule link to point to the style open bracket ce54acb DevTools: show name descriptions before formatted TypedArrays 3c412b0 DevTools: do not include unit_test_runner in resources.pak 8baafa7 [DevTools] call setScriptSource callback right after editing 1affe9b [DevTools] reveal debugger sidebar on pause c310407 DevTools: [Persistence] guard against multiple UISourceCodes with similar URL 0ce57e2 [Devtools] Update Acorn eefa79f DevTools: fix overlapping toolbars in Sources and SearchableViews c9b9b38 [Devtools] Update RJSMin 71051bd [Devtools] Fixes pressing CTRL in styles while editing deselects 563ec62 DevTools: support sourceMappingURL for the inline stylesheets 070d3e6 DevTools: omit remoteBase query param when starting a shared worker 9f64da2 [DevTools] Introduce Project.isServiceProject method. git-subtree-dir: resources/unpacked/devtools git-subtree-split: 48cfc73

… of https://codereview.chromium.org/2781863003/ ) Reason for revert: Breaks selection, don't think was necessary at first place! Original issue's description: > [DevTools] Filtered list enhancements > > Some enhancements that are needed for the frames menu but also seem > useful for other clients of the FilteredListWidget. > 1. Selection is preserved while the filter string is being updated. > 2. Items are highlighted on hover. Provider is notified when mouse > moves over the item. > 3. It is now possible to set the selection. > > BUG=698027 > > Review-Url: https://codereview.chromium.org/2781863003 > Cr-Commit-Position: refs/heads/master@{#460799} > Committed: https://chromium.googlesource.com/chromium/src/+/76c041dbcc4de828135d0af8c39256c4861b1a01 TBR=dgozman@chromium.org,caseq@chromium.org,eostroukhov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=698027 Review-Url: https://codereview.chromium.org/2793483002 Cr-Commit-Position: refs/heads/master@{#461239}

6fc9410 [DevTools] Remove SDKModels' fromTarget methods 074cd71 DevTools: carefully cleanup javascript sourcemaps 152f290 DevTools: bring coverage view out of experiment fac11b9 Revert of [DevTools] Filtered list enhancements (patchset #4 id:60001 of https://codereview.chromium.org/2781863003/ ) f805f96 DevTools: Allow tabbing in and out of TextPrompt e77d772 DevTools: ViewContainer shouldn't be a tab stop e87afb1 DevTools: Show top level event initiator when a child is selected. cd06845 DevTools: Focus indicators in Toolbars 1179da2 DevTools: kill nested SVGs from icon spritesheets 9c6d01e DevTools: Adopt nbsp as unit & thousands separator for broader font support 1c10622 DevTools: add landing page to Coverage ed75064 DevTools: fix adding excluded folder from settings screen 629abaa DevTools: fix CSS sourcemap to be populated for multilpe sourcemaps scenario 46c3768 DevTools: fix overlap in computed styles widget 1731c39 DevTools: support UISourceCode rename in automapping 9d17ac1 Reland of [DevTools] Migrate SoftContextMenu to use GlassPane (patchset #1 id:1 of https://codereview.chromium.org/2771413006/ ) 2fbbb11 DevTools: call decorator.decorate() within CM operation 8c8d4ea [DevTools] Filtered list enhancements git-subtree-dir: resources/unpacked/devtools git-subtree-split: 6fc9410

…mPoint" This reverts commit dd944882a245a5117b50cb417138d92f32d931d6. Reason for revert: This causes WebKit Linux Trusty ASAN buildbot failure. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN/builds/8618 23:46:29.565 3877 ==1==ERROR: AddressSanitizer: use-after-poison on address 0x7ead60c0dbf0 at pc 0x00000dca937a bp 0x7ffd86b90c10 sp 0x7ffd86b90c08 23:46:29.565 3877 READ of size 8 at 0x7ead60c0dbf0 thread T0 (content_shell) 23:46:29.565 3877 #0 0xdca9379 in operator==<const blink::TreeScope, const blink::TreeScope> third_party/WebKit/Source/platform/heap/Member.h:128:27 23:46:29.565 3877 #1 0xdca9379 in blink::TreeScope::Retarget(blink::Element const&) const third_party/WebKit/Source/core/dom/TreeScope.cpp:393:0 23:46:29.565 3877 #2 0xdca8894 in blink::TreeScope::HitTestPointInternal(blink::Node*) const third_party/WebKit/Source/core/dom/TreeScope.cpp:267:10 23:46:29.565 3877 #3 0xdca8325 in HitTestPoint third_party/WebKit/Source/core/dom/TreeScope.cpp:254:10 23:46:29.566 3877 #4 0xdca8325 in blink::TreeScope::ElementFromPoint(double, double) const third_party/WebKit/Source/core/dom/TreeScope.cpp:245:0 23:46:29.566 3877 #5 0xc9353a7 in elementFromPoint third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h:38:23 Original change's description: > Fix retargeting of result in elementFromPoint and elementsFromPoint > > Currently elementFromPoint and elementsFromPoint are not per spec, and it may > return null incorrectly. This change adds retargeting of the result with > respect to the context object, and adds some tests that are similar to > elementFromPoint tests in WebKit, but with some corrected cases: > https://git.webkit.org/?p=WebKit-https.git;a=blob;f=LayoutTests/fast/shadow-dom/DocumentOrShadowRoot-prototype-elementFromPoint.html;h=a8dc4da2430713521b9ba77c742db10397a8e638;hb=HEAD > > Spec: > https://w3c.github.io/webcomponents/spec/shadow/#extensions-to-the-documentorshadowroot-mixin > > Bug: 759947 > Change-Id: I6aece5e9cc826124772c6ce13c806865055b2b9b > Reviewed-on: https://chromium-review.googlesource.com/808446 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Hayato Ito <hayato@chromium.org> > Reviewed-by: Takayoshi Kochi <kochi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531139} TBR=kochi@chromium.org,dgozman@chromium.org,hayato@chromium.org,pfeldman@chromium.org,rakina@chromium.org Change-Id: Id62abd371d93627d3178b63ca189cecfe9ff44d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 759947 Reviewed-on: https://chromium-review.googlesource.com/880264 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#531178}

darwin closed this as completed in 24a209c Feb 9, 2016

darwin added a commit that referenced this issue Nov 10, 2016

devtools: apply lost fix for #4 again

f326adc

see 24a209c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Console filter buttons act weird #4

Console filter buttons act weird #4

mtruyens commented Feb 7, 2016

Console filter buttons act weird #4

Console filter buttons act weird #4

Comments

mtruyens commented Feb 7, 2016