-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Transit EDN in Network Panel's request preview #1
Labels
Comments
babot
pushed a commit
that referenced
this issue
Jan 13, 2016
…tchset #1 id:1 of https://codereview.chromium.org/1567203004/ ) Reason for revert: This was a bad fix, breaks non-white toolbars (i.e. filter bar). Original issue's description: > DevTools: fix toolbar <select> background in Dark theme > > BUG=572706 > TBR=pfeldman@chromium.org > > Committed: https://crrev.com/50f67380499ef03afa7ebd83bbcfc9868791f1f3 > Cr-Commit-Position: refs/heads/master@{#368523} TBR=pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=572706 Review URL: https://codereview.chromium.org/1575123002 Cr-Commit-Position: refs/heads/master@{#368632}
babot
pushed a commit
that referenced
this issue
Jan 13, 2016
…tps://codereview.chromium.org/1575203003/ ) Reason for revert: Breaks responsive mode. Original issue's description: > [DevTools] More Device Mode polish. > > - fixed ruler in overlay with page scale factor; > - dimming zoom label based on some content being cropped; > - added dpr and ua type labels; > - fixed fit calculations; > - string updates. > > BUG=540864 > > Committed: https://crrev.com/a15860e14bdca7cba13cad960008e0581836b93b > Cr-Commit-Position: refs/heads/master@{#368822} TBR=dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=540864 Review URL: https://codereview.chromium.org/1574373002 Cr-Commit-Position: refs/heads/master@{#368950}
babot
pushed a commit
that referenced
this issue
Jan 13, 2016
…/codereview.chromium.org/1564363005/ ) Reason for revert: Breaks responsive design mode. Original issue's description: > [DevTools] Device Mode polish. > > - removed blueprints; > - reworked zoom; > - allowed sticky height (empty value); > - resizing on toggling rulers; > - layout adjustments; > - fixed wrong values in options menu. > > BUG=540864 > > Committed: https://crrev.com/22d8f1d01fc461524258b9856f326697f9b84b0c > Cr-Commit-Position: refs/heads/master@{#368686} TBR=dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=540864 Review URL: https://codereview.chromium.org/1581763002 Cr-Commit-Position: refs/heads/master@{#368952}
darwin
added a commit
that referenced
this issue
Jan 13, 2016
ee84143 DevTools: restore statusbar overflow ellipsis. f13c7cd Devtools: Remove unused events in StylesSidebarPane 4feb920 DevTools: include history items in the console suggest box. 9844585 DevTools: use timeout to release ignoreExecutionLineEvents flag 5dc7ddd [Media Router] Replace old MR extension ID with "new" extension ID. b5329c0 Revert of [DevTools] Device Mode polish. (patchset #1 id:1 of https://codereview.chromium.org/1564363005/ ) 9a15d38 Revert of [DevTools] More Device Mode polish. (patchset #1 id:1 of https://codereview.chromium.org/1575203003/ ) 6c41282 Devtools: Fix PauseInSharedWorkerInitialization test e519341 [DevTools] More Device Mode polish. 5b231ae Devtools CSS: Show custom variables in styles sidebar pane 714e010 DevTools: [profiler] high resolution sampling on by default 14be7d0 Add missing parenthesis to a DevTools protocol comment. 68d93e5 [DevTools] Removed unused code in SourceMap.js 763257c [DevTools] Fixed the rendering of the timeline flamechart, which was disappearing when scrolling the frames to the right with the arrow keys. afcece0 Devtools: Split InspectorBackend into two files 0f411ee [DevTools] Device Mode polish. e2268c1 DevTools: decode urls only on the presentation level. 2ccd467 DevTools: merge uisourcecode's url-alike members. af12426 Revert of DevTools: fix toolbar <select> background in Dark theme (patchset #1 id:1 of https://codereview.chromium.org/1567203004/ ) d1290f2 DevTools: Order the device list deliberately. 399bbc9 DevTools: fix toolbar <select> background in Dark theme c335daa DevTools: fix timeline banners to scroll on overflow c037c1d DevTools: fix selection adjustment in DataGrid 5ef30d6 DevTools: preserve hover state rendering upon tabbed pane tab selection. 787e525 [DevTools] Shows Manifest file in Sources tab d205ce8 Devtools: Add source offsets to keyframe animations git-subtree-dir: resources/unpacked/devtools git-subtree-split: ee84143
darwin
changed the title
Display EDN in Network Panel's request preview
Display Transit EDN in Network Panel's request preview
Jan 17, 2016
babot
pushed a commit
that referenced
this issue
Feb 12, 2016
… id:1 of https://codereview.chromium.org/1681013002/ ) Reason for revert: Huge blocks of text in inline values, scopechainsidebarpane BUG=586256 Original issue's description: > DevTools: [Console] wrap long strings in console > > The "white-space: pre" was introduced in crrev.com/1304033003 to avoid > spaces collapsing. > > The "white-space: pre-wrap" does not collapse spaces and wraps text > if needed. > > BUG=583644 > R=pfeldman, dgozman > > Committed: https://crrev.com/8fa870ed97a19658f438db9b9f5b3548cb47bf4a > Cr-Commit-Position: refs/heads/master@{#374292} TBR=dgozman@chromium.org,pfeldman@chromium.org,lushnikov@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=583644 Review URL: https://codereview.chromium.org/1689273002 Cr-Commit-Position: refs/heads/master@{#375006}
darwin
added a commit
that referenced
this issue
Feb 18, 2016
8893c96 DevTools Timeline: polish RAIL 7d6ac13 Indexed DB: Remove string version plumbing 86fc13c Revert of DevTools: add input event instrumentation test (patchset #2 id:40001 of https://codereview.chromium.org/1704723002/ ) 317b69e [DevTools] Use setTextAndTitle() to show tooltips in service workers view. 944f79f DevTools: expose major oilpan events in Timeline 8d8b8d3 DevTools: add input event instrumentation test b21deec [DevTools] Add sourceMap support for blackboxing d0f431d DevTools: capture javascript stack trace for asynchronous image requests. 9388936 DevTools: get rid of open types in the protocol generator. db0e036 Devtools: Prevent == $0 tip from causing changes to layout 971e746 [DevTools] Fix rendering options on small sizes 6ccd457 Devtools: Collapse drawer when console is open in both panel & drawer 25e8b57 DevTools: Add samling heap profiler support to BE and protocol b0acda5 DevTools: Fix closure compilation after -r375297 7325f0d DevTools: move protocol-related generators into inspector subfolder. 29360f6 DevTools: [Console] fix viewport stick-to-bottom behavior 464cfc6 [DevTools] Allow emulating "screen" media in addition to "print". 1714c32 Revert of [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart. (patchset #4 id:60001 of https://codereview.chromium.org/1679133002/ ) 31c568e Devtools Animations: Remove cached left value when resizing 78c4dd4 [DevTools] Do not enable touch emulation when inspect mode is already engaged. 5bf7edd [DevTools] Align media queries inspector with quick width presets strip. 6b48a2e Revert of DevTools: [Console] wrap long strings in console (patchset #1 id:1 of https://codereview.chromium.org/1681013002/ ) 726e6ef [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart. 5315df4 DevTools: [Console] speedup array autocompletion 0eda8b1 DevTools: bring search results counter to the left c592274 DevTools: Fix search causing OOM in CPU profile view on large profiles. 6b7b196 Devtools: Don't clear custom user agent on double click 778934e DevTools: Make timeline memory pane resizable with its header. dd95126 Filter input events on Timeline based on id of tracing target 13eff76 DevTools: better distribution of JS frames colors on flamechart. 5e27c13 DevTools: highlight frame when hovered in the Source panel navigator. dcf75c2 DevTools: increase width of "Search across all files" field cfdf433 [DevTools] Do not reset page scale on changing zoom. c96df75 DevTools: [Console] wrap long strings in console 8bf1937 DevTools: Fix network events positions on the network flamechart. 6b382b4 Devtools: Add metrics for drawer views being shown e3e27a9 [DevTools] Show values between 1Mb/s and 10Mb/s with one decimal point. e02af11 [DevTools] Do not clear manually entered height value in Device Mode. 83b6d1e [DevTools] Rename "accelerometer" to "device orientation", validate values. 5bd29fa DevTools: do not use platform/ to load injected scripts into inspector/v8. c1d97db update obsolete code.google.com documentation links d1f13d8 DevTools: Fix timeline memory pane checkbox alignment 9e6a579 [DevTools] Remove main -> emulation dependency. ab29e36 Devtools: Use Event.deepPath as a function if available. 3b52d7d Wrap UI strings for a table in the Security panel in UIString calls. git-subtree-dir: resources/unpacked/devtools git-subtree-split: 8893c96
babot
pushed a commit
that referenced
this issue
Feb 20, 2016
…expansions (patchset #1 id:1 of https://codereview.chromium.org/1713783003/ ) Reason for revert: Broke WebKit Linux webkit_tests: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/60992 Original issue's description: > DevTools: improve SCSS parser to correctly handle variable expansions > > The patch improves SCSS parser to not get stuck after encountering > variable expansion. > > BUG=527993 > R=pfeldman, dgozman > > Committed: https://crrev.com/dca95714bf140aa7f672ee80ae25a14ea7295eb2 > Cr-Commit-Position: refs/heads/master@{#376489} TBR=dgozman@chromium.org,pfeldman@chromium.org,lushnikov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=527993 Review URL: https://codereview.chromium.org/1712363002 Cr-Commit-Position: refs/heads/master@{#376533}
babot
pushed a commit
that referenced
this issue
Feb 24, 2016
…ScreenMetricsEmulator. (patchset #1 id:1 of https://codereview.chromium.org/1723663005/ ) Reason for revert: Meh, revert broke the tree. Revert revert, will investigate later. Original issue's description: > Revert of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (patchset #5 id:80001 of https://codereview.chromium.org/1711083002/ ) > > Reason for revert: > Suspected of breaking "fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html" on Webkit Linux Leak: > > -FAIL window.cached_screen_orientation.type should be . Was portrait-primary. > +FAIL window.cached_screen_orientation.type should be . Was landscape-primary. > > See: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/17650 > > Original issue's description: > > [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. > > > > This unifies screen orientation with the rest of screen emulation > > and covers window.orientation API. > > > > BUG=585185 > > > > Committed: https://crrev.com/c7185a793efbeaa40e0d20d9d953bc1e2c32f5d1 > > Cr-Commit-Position: refs/heads/master@{#376822} > > TBR=pfeldman@chromium.org,tsepez@chromium.org,dgozman@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=585185 > > Committed: https://crrev.com/abf86fd83c48a4dfa3f059f2db732fbb11cb614d > Cr-Commit-Position: refs/heads/master@{#376976} TBR=pfeldman@chromium.org,tsepez@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=585185 Review URL: https://codereview.chromium.org/1722643003 Cr-Commit-Position: refs/heads/master@{#376979}
darwin
added a commit
that referenced
this issue
Feb 29, 2016
2975ecf [DevTools] Add touch to sensors view. 6aada89 Timeline: extract and rename TracingModelLoader into a file of its own 2d4d494 DevTools: extract TimelineProfileTree into a file for better reuse 94e222e DevTools: [CSSP] do not wrap computed properties. 32c096c DevTools: Tweak timeline group headers drawing 8c6c1b4 [DevTools] Replace (un)blackboxURL methods with (un)blackboxUISourceCode 336beef DevTools: report resources as loaded upon failed request from workers. 21927a0 DevTools: [Console] do not replace '\t' control character b753ee4 [DevTools] Restore showViewportSizeOnResize. 1e5a8f6 [DevTools] Per debugger model state storage in BlackboxManager abd1fba Timeline: make flamechart groups collapsible b128f30 [DevTools] Disable JavaScript checkbox does not work. 880d35f DevTools: [Console] display control characters in console commands 6c90ade DevTools: [SASS] implement SASSProcessor.InsertProperties operation 03cdbcd Devtools: Allow filtered list widget keyboard navigation to wrap around 9edfc28 DevTools: [SASS] implement SASSProcessor.RemoveProperty operation 782faca Devtools: Switch JS execution context to match inspected node 33698a9 DevTools: [SASS] implement SASSProcessor.ToggleProperty operation a6d7338 [DevTools] Added Linkify.linkifyStackTraceTopFrame method 70ca603 DevTools: [SASS] add WI.SASSProcessor and first "setText" operation 058aca3 DevTools: [SASS] get rid of WI.ASTSourceMap.rebaseForCSSDiff/rebaseForSASSDiff a08075b [DevTools] Add "show throttling" to device mode instead of "configure network". 5a074fb Indexed DB: Rename "int version" to "version" 4c5344b DevTools: [CSS] fix CSS style formatter 75fb6f6 DevTools: remove oldText from SourceEdit 3a85dd8 [DevTools] Fix minor bugs in frontend. 2c24ca0 DevTools: [CSSP] make "goto source" icon crisp ff9eff8 DevTools: Extract SegmentedRange from TimelineIRModel to utilities.js cab214a Reland of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (patchset #1 id:1 of https://codereview.chromium.org/1723663005/ ) b0611c8 Revert of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (patchset #5 id:80001 of https://codereview.chromium.org/1711083002/ ) 69e96fb DevTools: migrate remote debugging protocol generators to jinja2. 22e4373 [DevTools] Make max-width media queries symmetric. 33be141 DevTools: remove FileSystem API inspection from experiments, point users to the extension. ecf45f5 [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. 4a73f2e [DevTools] Add device type to custom device presets. 9ae3c2c [DevTools] Restore show rulers functionality. 97f87ca [DevTools] Don't load sourcemap for blackboxed scripts a58cff0 [DevTools] Add sourceURL deprecation message for scripts 9bbd93f DevTools: [SASS] re-implement SASSSupport.Rule.insertProperties de2e154 DevTools: improve SCSS parser to correctly handle variable expansions ba5dd8b DevTools: [SASS] correctly add sass module 4af0766 DevTools: Make JSFrames occupy all the space between samples. ae10e88 DevTools: rename WI.SASSLiveSourceMap into WI.ASTSourceMap. c8d03ed Revert of DevTools: improve SCSS parser to correctly handle variable expansions (patchset #1 id:1 of https://codereview.chromium.org/1713783003/ ) 7a2d28f DevTools: improve SCSS parser to correctly handle variable expansions d41f526 DevTools: teach WI.CSSParser to parse style ranges 4c9b383 DevTools: introduce WI.ASTService instead of WI.SASSWorkspaceAdapter 55f115b DevTools: [Console] wrap long strings in console 4184a0d Revert: [DevTools] Removed support deprecated (//@|/*@) source(URL|MappingURL)= 2cc00e1 Animation: Add optional specified animation id e7ca2a5 DevTools: Make FlameChart._measureText use Map for caching. 8e8a476 DevTools: Reduce unattributed size in timeline tree view c8f0ddb [DevTools] Rework device scale factor and user agent type UI. dc9e2b3 DevTools: [CSS] Add CSS.setMultipleStyleTexts command to CSS domain 6cfae37 Timeline FlameChart: clean up a handful of redundant member fields be5c866 [DevTools] Blackboxing in LiveLocations is supported in Linkifier 44eeeb2 [DevTools] Replace let with var c296234 DevTools: Prepare for CPU profiler code events turn from Instant to Meta. f2eb763 [DevTools] Support CommandLineAPI in snippets c8ceef9 Revert of Change Event.deepPath to a method (patchset #4 id:60001 of https://codereview.chromium.org/1637813002/ ) a19117d DevTools: add input event instrumentation test 4e76f53 [DevTools] Add workaround for closure compiler for Event.prototype.deepPath 6b7cfe8 DevTools: remove bottom-up flame charts 3487e2c Change Event.deepPath to a method git-subtree-dir: resources/unpacked/devtools git-subtree-split: 2975ecf
babot
pushed a commit
that referenced
this issue
Mar 2, 2016
… of its own (patchset #1 id:1 of https://codereview.chromium.org/1752453002/ ) Reason for revert: Reverting of revert, it doesn't look to me this was the culprit in layout test failures. Original issue's description: > Revert of Timeline: extract and rename TracingModelLoader into a file of its own (patchset #4 id:60001 of https://codereview.chromium.org/1739193003/ ) > > Reason for revert: > Possible cause behind failure in webkit-tests on WebKit Mac10.11 and WebKit Mac10.11 (retina). > > Original issue's description: > > Timeline: extract and rename TracingModelLoader into a file of its own > > > > This just extracts TimelineLoader with the aim of later refactoring > > it to untangle timeline lifecycle events from TimelineModel. > > > > Committed: https://crrev.com/b994e8b0a8af48aca6aa2182b5e8157b4873c0e9 > > Cr-Commit-Position: refs/heads/master@{#378109} > > TBR=alph@chromium.org,caseq@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > > Committed: https://crrev.com/c4ffa58b1a2c1eb0484dc21b68632e96c070652c > Cr-Commit-Position: refs/heads/master@{#378291} TBR=alph@chromium.org,nektar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1754713002 Cr-Commit-Position: refs/heads/master@{#378464}
darwin
added a commit
that referenced
this issue
Mar 15, 2016
ec7586b DevTools: speedup tracing model event phases check. 13f9b8d DevTools: Remove vendor-prefixed css rule audit. f81a8eb Remove V8RecrusionScope, cleanup call sites. 1730f5c DevTools: [CSS] fix CSS pretty-print mapping. 6aa06db Timeline: moar collapsible groups polish on Flame Chart c9a1145 Devtools: Fix space key in Styles pane editing d466a1c Devtools: Command menu item scoring a4ae446 DevTools: Initial implementation of line-level CPU profile. ac71c29 DevTools: [Formatter] unify JavaScriptFormattedContentBuilder and CSSFormattedContentBuilder 364df9a Timeline: fix collapsible groups rendering in dark theme 7107128 DevTools: Do not invoke CPU throttling on worker targets. ab4dda0 DevTools: Make the colors for the same URL be the same for all recording. 7d03994 DevTools: [CSS] rename WI.CSSStyleModel into WI.CSSModel a80d023 Timeline: fix nested group visibility computation 34d3722 Timeline: fix exception when clicking on drawer padding with collapsible groups enabled 445c765 Timeline: show RAIL phase strip unconditionally on actual records being present ae734b5 DevTools: add readme to project root. b4cc6f0 Timeline: move eventStackFrame from TimelineTreeView to TimelineProfileTree f46adb2 Timeline: extract profile tree aggregator into a model-level class 5a5a874 DevTools: Support line markers in UISourceCode and Code Mirror 4d40c3f [DevTools] Removed unused hidden protocol method: getStepInPositions 7730a99 DevTools: fix FlameChart compile error due to mid-air collision with compiler roll b7f8409 [DevTools] Strip "get" and "set" prefixes when describing functions 3dfedf8 [DevTools] Enable user select / text copy in ServiceWorkersView. 7b580d6 [DevTools] Show viewport size on resize by default, disable in device mode. 5a90646 Devtools: truncate long strings in tooltip 89991cb Devtools: resolve expressions in minified scripts with sourcemaps e400a18 Timeline: add support for multi-level headers in flame chart e62a2c1 Updated devices with updates from github repository. d1ce20d DevTools: [Fonts] show if rendered font was loaded from internet 62b51eb [DevTools] Fix event listener sidebar c6cfba2 DevTools: generate string16-based handlers for v8_inspector. 38f07de [DevTools] Roll closure compiler to ToT version d43ba4a [DevTools] Regression: newly added throttling option is not selectable. 4625713 Remove primary load waterfall experiment from DevTools. 54b0caa DevTools: Add scroll bar to the JSON view. 02cd465 Timeline: extract TimelineController from TimelineModel f35a8ae [DevTools] Fix more frontend compiler errors bb56e56 DevTools: remove support for node annotations from Paint Profiler's front-end b4a19e7 [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart. 7222211 [DevTools] Fix compile errors before closure compiler roll 0c06c27 Handle emulated device scale factor and original device scale factor properly in use-zoom-for-dsf mode. 6d9eb43 [DevTools] Fix compiler errors in bindings module 33d4868 DevTools: mapify internal field in WI.CompilerScriptMapping 249d324 [DevTools] Prepare UI module for closure compiler roll 0f2ab46 Devtools: add Security panel to user metrics 1766d85 Devtools: resolve parameters names via sourcemaps fba03bb [DevTools] Remove Array.from method from utilities.js f7fc52c DevTools: promisify WI.SourceMap.load 8e9359b Devtools: Do not greedily collapse URLs 3732b03 DevTools: make AsyncCallFrame clickable in callstack sidebar. bf8e685 Devtools: Fix rendering of async callframes in CallStackSidebarPane eea93dc Devtools: Add a command menu b530136 Devtools: Use Runtime.StackTrace instead of Debugger.StackTrace in asyncs 15bef42 Timeline: quit using Progress, introduce TimelineLifecycleDelegate c3959d8 DevTools: [CSS] rename WI.CSSStyleModel.MatchedStyleResult into WI.CSSMatchedStyles 086e9bf DevTools: [CSS] cleanup WI.CSSStyleModel 6b37253 Timeline: fix timeline saving and make the test actually test it 9e786e0 Devtools: [Experiment] parse variables in scopes and sourcemap them a409066 DevTools: [CSS] split CSSStyleModel into multiple files ae3656e DevTools: [CSS] prepare CSSStyleModel to be split into multiple files d426b74 DevTools: generalize rebaseline for all of the CSSStyleModel types. e44f293 Timeline: merge TimelineModelLoadFromFileDelegate into TimelineLoader 47bf952 Devtools: remove async scopes 542adc7 Timeline: fix timeline saving so we don't write after close 6fe9de9 Remove webkit-background-composite 6224336 [DevTools] Add script content hash to scriptParsed protocol event dcd8017 Reland of Timeline: extract and rename TracingModelLoader into a file of its own (patchset #1 id:1 of https://codereview.chromium.org/1752453002/ ) 73af080 DevTools: [CSS] move matching selectors from WI.CSSStyleRule to WI.MatchedStyleResult ed69af4 Revert of Timeline: extract and rename TracingModelLoader into a file of its own (patchset #4 id:60001 of https://codereview.chromium.org/1739193003/ ) 8ae9005 Timeline: merge TimelineModelLoadFromFileDelegate into TimelineLoader 329a59a Devtools: Add guide line for selected/hovered node in DOM tree git-subtree-dir: resources/unpacked/devtools git-subtree-split: ec7586b
babot
pushed a commit
that referenced
this issue
Mar 23, 2016
…depending on device capabilities. (patchset #1 id:1 of https://codereview.chromium.org/1817523003/ ) Reason for revert: Speculative revert to see if it fixes edit-dom-actions.html on Win7 webkit bots, which started timing out with no useful output on both Oilpan and non-Oilpan on runs including this CL (e.g., https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/5007). Original issue's description: > DevTools: Select max resource size in NetworkResourcesData depending on device capabilities. > > BUG=587982 > > Committed: https://crrev.com/ee50736c96ca97939d5b99543f3e0b297fd88029 > Cr-Commit-Position: refs/heads/master@{#382325} TBR=dgozman@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=587982 Review URL: https://codereview.chromium.org/1825033002 Cr-Commit-Position: refs/heads/master@{#382556}
babot
pushed a commit
that referenced
this issue
Mar 23, 2016
…depending on device capabilities. (patchset #1 id:1 of https://codereview.chromium.org/1825033002/ ) Reason for revert: Reland the original CL as it's not the culprit ( https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Win7%20%28dbg%29&number=5017, which includes the revert, still has the test failure) Original issue's description: > Revert of DevTools: Select max resource size in NetworkResourcesData depending on device capabilities. (patchset #1 id:1 of https://codereview.chromium.org/1817523003/ ) > > Reason for revert: > Speculative revert to see if it fixes edit-dom-actions.html on Win7 webkit bots, which started timing out with no useful output on both Oilpan and non-Oilpan on runs including this CL (e.g., https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/5007). > > Original issue's description: > > DevTools: Select max resource size in NetworkResourcesData depending on device capabilities. > > > > BUG=587982 > > > > Committed: https://crrev.com/ee50736c96ca97939d5b99543f3e0b297fd88029 > > Cr-Commit-Position: refs/heads/master@{#382325} > > TBR=dgozman@chromium.org,pfeldman@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=587982 > > Committed: https://crrev.com/6592b9dbd6050a2e7b9f9f0174dc133d4647309b > Cr-Commit-Position: refs/heads/master@{#382556} TBR=dgozman@chromium.org,pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=587982 Review URL: https://codereview.chromium.org/1821103003 Cr-Commit-Position: refs/heads/master@{#382581}
darwin
added a commit
that referenced
this issue
Mar 25, 2016
791c2d1 [DevTools] Use InspectorFrontendHost.readyForTest for layout tests. 0d7fb63 [DevTools] Improve DOMPropertiesExpanded user metric 711d90c DevTools: Add functionName to FunctionCall event. 4700678 [DevTools] Remove websocket frontend API. b1cd0d9 DevTools: introduce SourceMap editable capability 475db6a DevTools: Introduce WI.SourceMap interface 664ebfb DevTools: Fix a deopt in FlameChart.timeToPosition 3486490 DevTools: Use live location for line level profile presentation. 082b570 DevTools: make sure scope variables do not throw exception e0662b3 [DevTools] Introduce InspectorFrontendHost.readyForTest. 651cc1b update label in styles pane 9d7fa42 DevTools: use WebInspector namespace instead of FormatterWorker d4b28e4 Reland of DevTools: Select max resource size in NetworkResourcesData depending on device capabilities. (patchset #1 id:1 of https://codereview.chromium.org/1825033002/ ) 2b55c82 Revert of DevTools: Select max resource size in NetworkResourcesData depending on device capabilities. (patchset #1 id:1 of https://codereview.chromium.org/1817523003/ ) 82aee18 Devtools: Remove duplicated shortcut for go to member in Sources da43a0c Devtools: Don't show color swatch for variables like var(--blue) 958ed98 Devtools: Reduce indentation in elements tree b2914d1 Devtools: Hide popover arrow when not able to position next to anchor 029d653 DevTools: fix breakpoints rendering 7e004a7 DevTools: split formatter worker into files 7b474d9 DevTools: [SASS] get rid of CSS/SASS words inside WI.ASTSourceMap ae67858 DevTools: simplify formatting of mixed HTML 8daf994 DevTools: mapify WI.DOMNode._markers 8fcdc3c DevTools: update ViewportDataGrid resizers when scrollbar visibility changes cfce0bb DevTools: Tooltip is shown wrong on hovering the mouse over element state marker in Elements tab. 401a88a Devtools: Fix command menu scoring 77c134b DevTools: Select max resource size in NetworkResourcesData depending on device capabilities. git-subtree-dir: resources/unpacked/devtools git-subtree-split: 791c2d1
babot
pushed a commit
that referenced
this issue
Apr 20, 2016
… (patchset #1 id:1 of https://codereview.chromium.org/1816933002/ ) Reason for revert: Breaks color picker with no easy fix: crbug.com/603811 Original issue's description: > Devtools: Cut color picker off at bottom instead of the top > > When there is insufficent vertical space, the color picker is cut off at > the top. This change fixes it at the top in these situations, allowing > better usability of the color picker in these states. > > BUG=572101 > > Committed: https://crrev.com/acc1963c73bc1e4dabf926d5f99d9323d2918016 > Cr-Commit-Position: refs/heads/master@{#386581} TBR=lushnikov@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=572101 Review URL: https://codereview.chromium.org/1900033002 Cr-Commit-Position: refs/heads/master@{#388127}
darwin
added a commit
that referenced
this issue
Apr 23, 2016
016fb2f [DevTools] Add Debugger.setBlackboxPatterns protocol method 066ae58 DevTools: Add a few more chromecast ids to the blacklist 15ddd9e DevTools: Fix annotation typo landed in cl/1907263002 35e1747 [DevTools] JSONView parsing smarter 738ee02 Update styling for rendering drawer panel d9fd81c DevTools: ConsolePanel should delegate focus() to ConsoleView. ecfee1c DevTools: Fix assorted JavaScript style issues. c332cca DevTools: Introduce eslint configuration. 3b23c18 DevTools: remove WebInspector.WorkerRuntime.FuturePort method ef46133 Devtools: Custom properties with colors should have a color swatch 46ae7ec DevTools: cleanup a batch of eslint style errors f4d96ef Update styles for network conditions drawer panel fb7310b Timeline: cleanup unused code 14ba56d DevTools: Rename ProfileDataGrid files 360fc8b Timeline: remove multipleTimelineViews experiment 168ca46 DevTools: Support Sampling Heap Profiler in DevTools eee43ed DevTools: add "search in folder" context menu item for folders in source navigator 684b5e0 DevTools: propogate ResolveVariableNames experiment from hidden to visible 23889d6 DevTools: rename totalSize to selfSize in sampling heap profiler protocol. 553a654 DevTools: Refactor profile trees: rename totalTime->total selfTime->self 72c64fc Add device frame svgs to devtools gypi 5e56139 DevTools: pretty-print HTML 02fb0e3 Expose SPDY pushes in DevTools 7935b35 DevTools: extract CPU profile independent part of CPUProfileNode. 5acdfaa DevTools: introduce the bypass service worker checkbox. 3e443a2 [DevTools] Initial implementation for an overflow option for displaying a device art outline in emulation mode. 1b00494 Revert of Devtools: Cut color picker off at bottom instead of the top (patchset #1 id:1 of https://codereview.chromium.org/1816933002/ ) 8c93cca [DevTools] Remove network headers filter experiment. bc577d1 [DevTools] Fix console-xpath.html test b9a34f4 [DevTools] Add sorting to all tabs in network git-subtree-dir: resources/unpacked/devtools git-subtree-split: 016fb2f
babot
pushed a commit
that referenced
this issue
Jun 28, 2016
…https://codereview.chromium.org/2085523003/ ) Reason for revert: https://chromium.googlesource.com/chromium/src/+/f2168263f19ab4f81c56d6258db7d9e6fa0b07fb already fixes this Original issue's description: > DevTools: Add autocomplete values for CSS contain > > BUG=619844 > > Committed: https://crrev.com/ae37548c093fd06e2c99e9ddcb3b18e36759b07d > Cr-Commit-Position: refs/heads/master@{#402270} TBR=dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619844 Review-Url: https://codereview.chromium.org/2101083002 Cr-Commit-Position: refs/heads/master@{#402339}
darwin
added a commit
that referenced
this issue
Jul 3, 2016
2b946eb [Devtools] Fixed websocket initiators 03159a0 DevTools: Fix a bug where user agent shadow dom elements were inspectable by recursively checking for shadow dom 67b5471 DevTools: fix deepActiveElement and focus on Dialog when document blurs 08001ae CT in DevTools: use "Source" rather than "Origin". 6e4adf6 [DevTools] Move Console to v8 inspector. 68fbc73 DevTools: Center vertically around a highlighted element cf57c6f [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier. 671e397 [DevTools] Move collectionEntries to internalProperties in protocol 52c463c Addition of Certificate Transparency details to Security panel of DevTools 06b9e50 Revert of [Devtools] Fixed websocket initiators (patchset #4 id:100001 of https://codereview.chromium.org/2094903002/ ) 480926e Revert of Add autocomplete values for CSS contain (patchset #1 id:1 of https://codereview.chromium.org/2085523003/ ) c4fea64 DevTools: eliminate race condition in WI.StylesSourceMapping. f117125 [Devtools] Fixed websocket initiators 1d09555 DevTools: Close all sources command 2bf8793 DevTools: Don't lowercase SVG and other XML-like elements 7f40f91 DevTools: Add autocomplete values for CSS contain 31710e7 Show the size of images in a picture element Also fix a small bug where srcsets without a resolution wouldn't get a preview 5a4cb9d DevTools: add CSS completion for contain property. 5d3f372 DevTools: render markers as circles on the main timeline. git-subtree-dir: resources/unpacked/devtools git-subtree-split: 2b946eb
babot
pushed a commit
that referenced
this issue
Jul 26, 2016
…1 of https://codereview.chromium.org/2147343002/ ) Reason for revert: [Devtools] Broke header tabs in network tab BUG=630971 Original issue's description: > DevTools: cleanup treeoutline expand logic > > TreeElement.expand() should not need to check that the element has children and > TreeOutline.insertChild() should not automatically expand a child when it is > inserted. ObjectPropertiesSection.js depended on this logic to automatically > expand the Entries property. This CL updates it so that the Entries property is > added before expanded. > > BUG= > > Committed: https://crrev.com/cf5b729f072ba670c7b9966407fb3d47eb2169e7 > Cr-Commit-Position: refs/heads/master@{#407061} TBR=lushnikov@chromium.org,luoe@chromium.org Review-Url: https://codereview.chromium.org/2182783002 Cr-Commit-Position: refs/heads/master@{#407801}
darwin
added a commit
that referenced
this issue
Jul 27, 2016
6bad132 Revert of DevTools: cleanup treeoutline expand logic (patchset #1 id:1 of https://codereview.chromium.org/2147343002/ ) 88a154f DevTools: update css for Remote Devices drawer panel 8f09224 [DevTools] Better locations for snippets 2990ca1 DevTools: follow up to the widget hierarchy change, account for local widget reparending. 0e53c6c [DevTools] No longer store security origins in RTM 30fcf52 [DevTools] Do not use "settings" query param. d981140 DevTools: traverse widget hierarchy to reveal views. 6b52111 DevTools: disable "lineWiseCopyCut" CodeMirror option. b452544 DevTools: update list of CSS properties that are color aware 89338eb [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public. c6c550c DevTools: follow-up to view introduction, fix styles css. a5c233d DevTools: roll CodeMirror 5.17.1 Fixing soft undo 01a9c01 DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide (reland) 5d69fad DevTools: Allow ESC for source color picker 3da8d7c DevTools: Sourcemap failure shouldn't open console drawer. 840152b DevTools: [SSP] simplify Control-Click functionality 5881e0a DevTools: remove isTrusted check and isUserGesture from ViewportControl 312effe DevTools: cleanup treeoutline expand logic 6f1379d DevTools: Fix Ctrl-Z for source color picker e40d1a8 DevTools: Immediately hide on scroll for source color picker 4c68e86 DevTools: make all timeline trace events use 0-based line numbers 5db55e4 Revert of DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide. (patchset #3 id:40001 of https://codereview.chromium.org/2157363006/ ) e0158a2 DevTools: Set mouse cursor to default when hovering over color swatch 4c0368e DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide. 5dc7504 DevTools: fix computed style pane layout 02e7968 DevTools: Added package.json, LICENSE, and .npmignore 1834b66 DevTools: Fix presubmits failing on InspectorFrontendHostAPI d253713 DevTools: Add reload button to disconnection dialog b520ad6 [DevTools] Remove Object.values and Object.isEmpty from utilities.js dc02602 DevTools: Change a few implicit globals to explicit globals. 0bce15a DevTools: Source color picker experiment. Make color swatches clickable 1db2194 DevTools: roll front_end/sdk/protocol files 76bb451 [DevTools] Move "Continue to first invocation" experiment to hidden b5b583f [DevTools] Make NetworkAgent.Initiator 0-based e8262af DevTools: introduce View: a named widget with the toolbar. 939b708 [DevTools] Make WebInspector.ConsoleMessage 0-based 8f6d4b9 DevTools: Use proper target when processing worker thread events. 44c007e DevTools: remove WI.SourcesView._currentUISourceCode 487b5e0 [DevTools] Introduce DOM capability. 48e8a60 [DevTools] Move browser logging from Console domain to Log domain. 7228d61 DevTools: Move WebInspector.SwatchPopoverHelper into new file ui/SwatchPopoverHelper.js b7d17e5 [DevTools] Remove toProtocolValue from v8_inspector/public. 8d097c0 [DevTools] Fix links for JSFrame records in timeline 5915191 Remove FileError interface 9cfcb7a Fix compilation error after r406140 1b8616a Revert of Make the extension's sidebar pane auto-resizable. (patchset #7 id:120001 of https://codereview.chromium.org/1905493002/ ) f0cd1db DevTools: Do not linkify to pseudo (program) node when there's no URL 91ab1e8 [Devtools] Code cleanup - ensure no double-semicolons debf816 DevTools: Added empty implementation of navigationRequested method in frontend 888e1a8 DevTools: Rename StylesPopoverHelper to SwatchPopoverHelper git-subtree-dir: resources/unpacked/devtools git-subtree-split: 6bad132
babot
pushed a commit
that referenced
this issue
Aug 11, 2016
…r is confused. (patchset #1 id:1 of https://codereview.chromium.org/2226163002/ ) Reason for revert: https://codereview.chromium.org/2229683002 landed so we don't need this any longer Original issue's description: > DevTools: do not use string templates in front-end, minifier is confused. > > R=paulirish > BUG=623983 > > Committed: https://crrev.com/79df4803990d12f67cbaba6d912673d163baac12 > Cr-Commit-Position: refs/heads/master@{#410842} TBR=pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623983 Review-Url: https://codereview.chromium.org/2224173005 Cr-Commit-Position: refs/heads/master@{#411208}
babot
pushed a commit
that referenced
this issue
Aug 16, 2016
…d ones. (patchset #1 id:1 of https://codereview.chromium.org/2249743002/ ) Reason for revert: Compile failed on Linux ChromiumOS GN https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/44080 ../../headless/lib/headless_devtools_client_browsertest.cc:177:56: error: no member named 'Run' in 'headless::runtime::ExperimentalDomain' devtools_client_->GetRuntime()->GetExperimental()->Run( ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ../../headless/lib/headless_devtools_client_browsertest.cc:178:18: error: no member named 'RunParams' in namespace 'headless::runtime' runtime::RunParams::Builder().Build()); ~~~~~~~~~^ Original issue's description: > [DevTools] Rename entities in js_protocol, remove deprecated ones. > > BUG=635947 > > Committed: https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb > Cr-Commit-Position: refs/heads/master@{#412043} TBR=pfeldman@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635947 Review-Url: https://codereview.chromium.org/2249663003 Cr-Commit-Position: refs/heads/master@{#412052}
darwin
added a commit
that referenced
this issue
Aug 17, 2016
077fee1 DevTools: Standardize box shadows 2673630 Revert of [DevTools] Rename entities in js_protocol, remove deprecated ones. (patchset #1 id:1 of https://codereview.chromium.org/2249743002/ ) da1ed46 [DevTools] Rename entities in js_protocol, remove deprecated ones. e7d8154 Start sending auxclick instead of click for non-primary buttons 088d8b2 Add Server-Timing support to devtools edab929 DevTools: Do not remove custom CPU throttling value. bb5b63f DevTools: Show warning icon on the tab strip when CPU throttling is enabled. 6a36b0a [DevTools] Removed isInternalScript flag from protocol 94d67e9 [DevTools] Simplify evaluation callbacks on frontend 09d0f27 DevTools Security Panel: Use the new security indicators. 654c228 DevTools: fix stick to bottom in console viewport ff6ec40 [DevTools] Removed wasThrown from evaluate-like protocol methods c7d2221 [DevTools] Removed deprecatedCommentWasUsed flag from protocol scriptParsed 58e2006 DevTools: Move small icons from toolbarButtonGlyphs.svg to smallIcons.svg 21c8b55 DevTools: Override browser commit hash with process.env.CHROMIUM_COMMIT f938c7a DevTools: Automatically compile snippets 3a5f307 DevTools: WI.NavigatorView._removeUISourceCode should not remove frame nodes ada70d4 DevTools security panel: Hide origins sidebar on interstitials 1418c2e DevTools: Make sure the worker instance is not collected while the promise is in flight. 1921f19 DevTools: kill Array.prototype.keySet() method 3b1f529 DevTools: Remove unused swatch CSS 25da0ef DevTools: migrate some of the sources panel sidebar panes to view management, allow view toolbars. dd649a2 [Devtools] Filtering in the Network panel as ORing two regex tests breaks 1ce9dc8 Remove AnimationEffectTimingProperties playbackRate 296e56d DevTools: Add custom CPU throttling option to timeline. 4cf8315 Revert of DevTools: do not use string templates in front-end, minifier is confused. (patchset #1 id:1 of https://codereview.chromium.org/2226163002/ ) a107a8d [DevTools] Simplify text editor autocomplete. git-subtree-dir: resources/unpacked/devtools git-subtree-split: 077fee1
darwin
added a commit
that referenced
this issue
Aug 17, 2016
REVERT: 077fee1 DevTools: Standardize box shadows REVERT: 2673630 Revert of [DevTools] Rename entities in js_protocol, remove deprecated ones. (patchset #1 id:1 of https://codereview.chromium.org/2249743002/ ) git-subtree-dir: resources/unpacked/devtools git-subtree-split: da1ed46
darwin
added a commit
that referenced
this issue
Aug 17, 2016
52c36e6 DevTools: Refactor Profiler domain interface 5b5a787 DevTools: Use png icon for bezier editor b95270c DevTools: Repick execution context when frames are loaded d2cdcdc [DevTools] Rename entities in js_protocol, remove deprecated ones. f75d989 DevTools: do not load workers from the cloud in the debug mode. 2fb9635 DevTools: follow up to the sources views, make setting screen apear, make shortcuts a simple view. f0784e9 DevTools: migrate sources panel sidebar to views. 077fee1 DevTools: Standardize box shadows 2673630 Revert of [DevTools] Rename entities in js_protocol, remove deprecated ones. (patchset #1 id:1 of https://codereview.chromium.org/2249743002/ ) git-subtree-dir: resources/unpacked/devtools git-subtree-split: 52c36e6
Reposted as #37 |
babot
pushed a commit
that referenced
this issue
Oct 12, 2016
…id:1 of https://codereview.chromium.org/2404533002/ ) Reason for revert: This broke elements panel hovering. crbug.com/654702 Original issue's description: > DevTools: render element tree hover as a block. > > Committed: https://crrev.com/397f5d56c49c89fec520dbd37bd09880d5c68e42 > Cr-Commit-Position: refs/heads/master@{#424062} TBR=dgozman@chromium.org,pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2409293003 Cr-Commit-Position: refs/heads/master@{#424537}
darwin
added a commit
that referenced
this issue
Oct 14, 2016
433b36f DevTools: accept multiple service connections to dt backend. f8f9933 [Devtools] Bug fix of event dividers not showing in network panel dc059ab DevTools: update styles for debugger's CallStackSidebarPane aaecc7b DevTools: use services infrastructure for shared workers (temp storage). e13243e DevTools: restore selected panel upon devtools reload. (a follow-up to tabbed location migration). e76512f DevTools: throttle updates of layers panel when layer tree changes c9c938b DevTools: migrate InspectorView to tabbed view location. b0c3a48 DevTools: fix selection persistance when user switches back and forth from Layers panel 82fb90b DevTools: move overview grid window curtains handling into said window a973be8 DevTools: teach WI.IsolatedFileSystem to memorize folders with .git directory f25f93f Add auxclick to the devtool event listeners 9dffe65 Timeline: fix paint profiler image view 7bc9b57 [Devtools] Added row decoration to canvas timeline experiment 20a6bf8 [Devtools] Added data to networking timeline canvas experiment 1d4fdf5 DevTools: fix NPE in paint profiler when selection is made on empty profile d976c00 Revert of DevTools: render element tree hover as a block. (patchset #1 id:1 of https://codereview.chromium.org/2404533002/ ) c4cd9eb DevTools: Remove legacy experimental v8 sampling format support from front-end. fca245a DevTools: split LayerTreeModel accross different modules 93957f0 DevTools: fix exception in WI.TabbedEditorContainer git-subtree-dir: resources/unpacked/devtools git-subtree-split: 433b36f
babot
pushed a commit
that referenced
this issue
Nov 2, 2016
…(patchset #1 id:1 of https://codereview.chromium.org/2465373002/ ) Reason for revert: I'll reapply it. Original issue's description: > [Devtools] Fix network timeline canvas selection splitview > > This patch fixes a regression caused when a user selects a request > in the new network canvas timeline it would show the canvas to the left > instead of the name column. > > R=dgozman > BUG=653738 TBR=dgozman@chromium.org,allada@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=653738 Review-Url: https://codereview.chromium.org/2472523002 Cr-Commit-Position: refs/heads/master@{#429097}
babot
pushed a commit
that referenced
this issue
Nov 2, 2016
…ne overview (patchset #1 id:1 of https://codereview.chromium.org/2471553002/ ) Reason for revert: I'll reland it after the reformat. Original issue's description: > DevTools: Make curtain handle dragging work again in Timeline overview > > Committed: https://crrev.com/bb6a29b2d089961599eaa80bf3bf43ea1f11a734 > Cr-Commit-Position: refs/heads/master@{#429083} TBR=caseq@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2470913002 Cr-Commit-Position: refs/heads/master@{#429098}
darwin
added a commit
that referenced
this issue
Nov 2, 2016
211088e Revert of DevTools: Make curtain handle dragging work again in Timeline overview (patchset #1 id:1 of https://codereview.chromium.org/2471553002/ ) 8e68d61 Revert of [Devtools] Fix network timeline canvas selection splitview (patchset #1 id:1 of https://codereview.chromium.org/2465373002/ ) 1013526 [Devtools] Fix network timeline canvas selection splitview ba9481e DevTools: Make curtain handle dragging work again in Timeline overview ee09adf DevTools: Automagically detect user compiled content shell in npm test 2570bdd [Devtools] New network canvas timeline now properly shows initiators 10b90f9 [Devtools] Fixed contextmenu double showing for network requests 5cdc95c [Devtools] Added default width to canvas timeline in network panel exp 1a83d0c [Devtools] Fixed dividers in new network canvas timeline f546cd5 [Devtools] Fixed contextmenu in network timeline experiment. 7a7b873 [Devtools] Fixed scrollers for new timeline canvas on mac dd34560 DevTools: Have ExecutionContext.completionsForExpression return a promise git-subtree-dir: resources/unpacked/devtools git-subtree-split: 211088e
babot
pushed a commit
that referenced
this issue
Jan 25, 2017
…atchset #1 id:1 of https://codereview.chromium.org/2600493002/ ) Reason for revert: It turned out the icons are actually wrong. Compare: - Without this patch (correct): http://imgur.com/a/eFCnz - With this patch (incorrect): http://imgur.com/a/gJ24q Original issue's description: > DevTools: Correct Source Panel Show/Hide Toolbar buttons > > Regression : Misalignment of 'Hide Navigator' and 'Hide Debugger' buttons is seen in devtools. > > Flipped mask positions and removed—now unnecessary—rotation transforms around show/hide panel icon containers. > > BUG=671930 > R=lushnikov@chromium.org > TEST=Open Dev Tools, open Sources Pane, observe show/hide sidebar buttons > are correctly aligned. crbug.com/671930 > > Review-Url: https://codereview.chromium.org/2600493002 > Cr-Commit-Position: refs/heads/master@{#445339} > Committed: https://chromium.googlesource.com/chromium/src/+/4d2364eb32a5b242790324536efccd843cb81aa8 TBR=dgozman@chromium.org,pfeldman@chromium.org,me@jakehendy.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=671930 Review-Url: https://codereview.chromium.org/2655793003 Cr-Commit-Position: refs/heads/master@{#445983}
darwin
added a commit
that referenced
this issue
Jan 25, 2017
f4c45a0 [devtools] Support different encodings for Page.CaptureScreenshot. 2cde168 Revert of DevTools: Correct Source Panel Show/Hide Toolbar buttons (patchset #1 id:1 of https://codereview.chromium.org/2600493002/ ) 53bf5fa Timeline: remove the remains of TimelineModel.Record 4a470d6 DevTools: convert datagrid and network waterfall sort icons to UI.Icon c6ec1da [DevTools] Support BreakReason.OOM 830adfe [DevTools] Fix overflow in devices view. ca89e20 DevTools: Console: Provide autocompletions for Maps 6a0cd76 DevTools: fix network waterfall sorting icon 1ac9326 Timeline: rewrite TimelineUIUtils.buildRangeStats() to work without TimelineRecord bbdd9d2 DevTools: render (verbose|info) (intervensions|deprecations|violations) with warning background. db4c148 Revert of DevTools: Console: Provide autocompletions for Maps (patchset #6 id:100001 of https://codereview.chromium.org/2639703002/ ) 4da9dcd [DevTools] Hide empty toolbars f1eb331 DevTools: introduce object previews experiment 4e4a20f DevTools: Console: Provide autocompletions for Maps 50f80e6 DevTools: align tabbed pane close tab buttons. 3be25d0 Revert of [devtools] Support different encodings for Page.CaptureScreenshot. (patchset #8 id:480001 of https://codereview.chromium.org/2592983002/ ) git-subtree-dir: resources/unpacked/devtools git-subtree-split: f4c45a0
babot
pushed a commit
that referenced
this issue
Jan 28, 2017
…patchset #1 id:1 of https://codereview.chromium.org/2650213005/ ) Reason for revert: Breaks all the radio buttons Original issue's description: > DevTools: Move radio button input element into Shadow DOM > > BUG=685385 > > Review-Url: https://codereview.chromium.org/2650213005 > Cr-Commit-Position: refs/heads/master@{#446606} > Committed: https://chromium.googlesource.com/chromium/src/+/b115a08ad32ae5beda325c98ba50446b7e034eab TBR=dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=685385 Review-Url: https://codereview.chromium.org/2661623003 Cr-Commit-Position: refs/heads/master@{#446843}
darwin
added a commit
that referenced
this issue
Jan 28, 2017
1669375 DevTools: Type all properties in SuggestBox dfc4a90 DevTools: replace the settings icon with gear. ed6ef78 [DevTools] Make all SDKModels take a single argument in constructor. 2429f0c DevTools: Turn pie chart into a donut chart. d553999 DevTools: Make checkbox labels clickable again 8f72fab Revert of DevTools: Move radio button input element into Shadow DOM (patchset #1 id:1 of https://codereview.chromium.org/2650213005/ ) 0f63c02 DevTools: skip specific tests for backwards compatibility testing 7a18812 [DevTools] exposed promise creation frame in call stack sidebar 2c0cd6a DevTools: render console level filter as drop box. a7204bd [Devtools] Added padding to child nodes in network group experiment b80aa2a DevTools: Update network overview with two level bars. 2abe3dd DevTools: flip lighthouse binary to be a remote module. 50ab93d DevTools: Make datagrid default layout compact again. 2762b74 Timeline: move filters to TimelineTreeView, where they're actually used 3995c40 [DevTools] Center console icons vertically. git-subtree-dir: resources/unpacked/devtools git-subtree-split: 1669375
babot
pushed a commit
that referenced
this issue
Feb 24, 2017
…id:1 of https://codereview.chromium.org/2689213012/ ) Reason for revert: Per UX folks request Original issue's description: > DevTools: Add icons to performance pane tabs. > > BUG=693238 > > Review-Url: https://codereview.chromium.org/2689213012 > Cr-Commit-Position: refs/heads/master@{#451321} > Committed: https://chromium.googlesource.com/chromium/src/+/8376a0c3554ffb329e74e899f4277f7a80b52448 TBR=paulirish@chromium.org,caseq@chromium.org,kozyatinskiy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=693238 Review-Url: https://codereview.chromium.org/2714923002 Cr-Commit-Position: refs/heads/master@{#452752}
darwin
added a commit
that referenced
this issue
Feb 26, 2017
82a742e DevTools: Highlight DOM node on hover in flamechart. 8effe00 [DevTools] Unify Target.id and targetId. a7603f6 CSS coverage: switch to Common.TextRange and fix off-by-one in gutter 58bf952 DevTools: implement release note behind an experiment 0998659 [DevTools] Fix 'node targets available' not appearing, but listed in Remote Devices drawer tab. 9f71c80 DevTools: add eslint rule for arrow function parameter parens 429b829 DevTools: Merge ProfileLauncherView and MultiProfileLauncherView a1a3a8e DevTools: Show decoded body length for network requests on timeline. 252ff04 [DevTools] Do not collapse toolbars f98c950 Revert of DevTools: Add icons to performance pane tabs. (patchset #1 id:1 of https://codereview.chromium.org/2689213012/ ) 5cc310f [DevTools] Simplify Popover api. 64cfcbe DevTools: Do not show radio buttons on CPU profiler panel. b122740 [DevTools] Support multiple targets in heap profiler (properly). 8141d3c DevTools: rename CSSTracker to Coverage 329821e [DevTools] prepare getPossibleBreakpoints before rolling V8 bff0cdc DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible. 50551ed [DevTools] Do not access heapProfilerAgent directly. 6bf08d2 [DevTools] Move Popover to shadow DOM. a3ec910 [DevTools] Use a single CookieItemsView instance git-subtree-dir: resources/unpacked/devtools git-subtree-split: 82a742e
babot
pushed a commit
that referenced
this issue
Mar 4, 2017
…autocomplete. (patchset #1 id:1 of https://codereview.chromium.org/2729743002/ ) Reason for revert: Not sure this works in all cases Original issue's description: > [DevTools] Move 'this' evaluation from ExecutionContext to autocomplete. > > It's only used by autocomplete logic. > > BUG=none > > Review-Url: https://codereview.chromium.org/2729743002 > Cr-Commit-Position: refs/heads/master@{#454729} > Committed: https://chromium.googlesource.com/chromium/src/+/7791a3fc003f99454ca8cbdcfbbb8d28a0c6c1af TBR=einbinder@chromium.org,caseq@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review-Url: https://codereview.chromium.org/2728133004 Cr-Commit-Position: refs/heads/master@{#454746}
darwin
added a commit
that referenced
this issue
Mar 4, 2017
eae34e4 Revert of [DevTools] Move 'this' evaluation from ExecutionContext to autocomplete. (patchset #1 id:1 of https://codereview.chromium.org/2729743002/ ) 398859c [DevTools] Move 'this' evaluation from ExecutionContext to autocomplete. 11b4bbe DevTools: add metrics for command menu/quick open 658254c DevTools: do not update timeline tree view details if not visible. 9897b99 DevTools: Remove monospace from FilteredListWidget f055b38 DevTools Timeline: fix NPE when collapsing the last group 10af4da Timeline: fix NPE in heavy stack view when clearing Timeline 64854c0 DevTools: keep count instead of boolean wasUsed internally b70b505 Timeline: fix NPE when hovering over Interactions strip d440cf6 DevTools: move the filtered items caption into the toolbar. 23ca7f7 DevTools: sort sourceMap mappings since they might not be ordered. e4336f6 DevTools: finalize audits2 worker as remote module 0198df1 [DevTools] 'Continue to location markers' should be always correctly shown 587f32a DevTools: Support reading CPU profile format on Performance panel 50a62de DevTools: Collect UMA on CPU profile "focus" & "exclude" 214d1b6 DevTools: debug remote modules loaded by ServiceManager 7ac4fb3 DevTools: assorted polish for coverage pane b5cfdfb [Devtools] Fixed flicker in network for large stream of requests git-subtree-dir: resources/unpacked/devtools git-subtree-split: eae34e4
babot
pushed a commit
that referenced
this issue
Mar 21, 2017
…d:1 of https://codereview.chromium.org/2749423003/ ) Reason for revert: It needs more UX work. Original issue's description: > DevTools: launch What's New from experiments > > This is intended to gather feedback in Canary and then > we'll add another set of release notes before the next branch point. > > BUG=682879 > > Review-Url: https://codereview.chromium.org/2749423003 > Cr-Commit-Position: refs/heads/master@{#457598} > Committed: https://chromium.googlesource.com/chromium/src/+/9f061aa07fd7c89d8f1b0c3ddedc158c60939220 TBR=chenwilliam@chromium.org NOTRY=true BUG=682879 Review-Url: https://codereview.chromium.org/2759223002 Cr-Commit-Position: refs/heads/master@{#458182}
darwin
added a commit
that referenced
this issue
Mar 22, 2017
b68fd2e [Devtools] Fix offline checkbox state sharing across Network and Application>Service Workers panels 73a2c5b DevTools: Add 'caret-color' CSS property to _colorAwareProperties 9db9a2b Add certificate error handling to devtools. 8713e2d [DevTools] Rework Popover API bfea3be [DevTools] Fallback to MainFrameNavigated event url in Security panel 2b57967 DevTools: Tweak flamechart selection d04622a DevTools: kill Common.Throttler.flush() method dbfaa60 DevTools: introduce SDK.SourceMapManager a221e62 [DevTools] Remove dependency from TargetManager to ResourceTreeModel fdd03a0 [DevTools] Update SecurityDetails in Security panel if State changes 6628483 DevTools: Fix Network panel warning icon display when offline/throttled 57f5212 Revert of DevTools: launch What's New from experiments (patchset #1 id:1 of https://codereview.chromium.org/2749423003/ ) c8477b2 DevTools: Only show gutter diff for Network UISourceCodes ccc15d9 [DevTools] Wait for cachedResourcesLoaded in ConsoleModel git-subtree-dir: resources/unpacked/devtools git-subtree-split: b68fd2e
babot
pushed a commit
that referenced
this issue
Mar 31, 2017
#1 id:1 of https://codereview.chromium.org/2771413006/ ) Reason for revert: The regression was fixed in https://codereview.chromium.org/2776263006/ Original issue's description: > Revert of [DevTools] Migrate SoftContextMenu to use GlassPane (patchset #2 id:20001 of https://codereview.chromium.org/2778623002/ ) > > Reason for revert: > Broke DevTools settings > > Original issue's description: > > [DevTools] Migrate SoftContextMenu to use GlassPane > > > > Let the GlassPane handle all the tricky details about positioning. > > > > BUG=none > > TBR=lushnikov@chromium.org,dgozman@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=none > > Review-Url: https://codereview.chromium.org/2771413006 > Cr-Commit-Position: refs/heads/master@{#460228} > Committed: https://chromium.googlesource.com/chromium/src/+/ac4d06a47287a0303deac7879251b476d0de3b46 TBR=lushnikov@chromium.org,alph@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none Review-Url: https://codereview.chromium.org/2790613003 Cr-Commit-Position: refs/heads/master@{#460911}
darwin
added a commit
that referenced
this issue
Apr 2, 2017
6fc9410 [DevTools] Remove SDKModels' fromTarget methods 074cd71 DevTools: carefully cleanup javascript sourcemaps 152f290 DevTools: bring coverage view out of experiment fac11b9 Revert of [DevTools] Filtered list enhancements (patchset #4 id:60001 of https://codereview.chromium.org/2781863003/ ) f805f96 DevTools: Allow tabbing in and out of TextPrompt e77d772 DevTools: ViewContainer shouldn't be a tab stop e87afb1 DevTools: Show top level event initiator when a child is selected. cd06845 DevTools: Focus indicators in Toolbars 1179da2 DevTools: kill nested SVGs from icon spritesheets 9c6d01e DevTools: Adopt nbsp as unit & thousands separator for broader font support 1c10622 DevTools: add landing page to Coverage ed75064 DevTools: fix adding excluded folder from settings screen 629abaa DevTools: fix CSS sourcemap to be populated for multilpe sourcemaps scenario 46c3768 DevTools: fix overlap in computed styles widget 1731c39 DevTools: support UISourceCode rename in automapping 9d17ac1 Reland of [DevTools] Migrate SoftContextMenu to use GlassPane (patchset #1 id:1 of https://codereview.chromium.org/2771413006/ ) 2fbbb11 DevTools: call decorator.decorate() within CM operation 8c8d4ea [DevTools] Filtered list enhancements git-subtree-dir: resources/unpacked/devtools git-subtree-split: 6fc9410
babot
pushed a commit
that referenced
this issue
Apr 26, 2017
…hset #1 id:1 of https://codereview.chromium.org/2840463003/ ) Reason for revert: Suspected cause of failure of virtual/threaded/inspector/tracing/timeline-js/timeline-runtime-stats.html in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)/builds/9644 Original issue's description: > DevTools: fix aggregated donut chart cache population > > The check for stats cache availablity was made on the first task in the main thread > tasks list. If the first task happens to be filtered out, it never gets cache built for > it. Later the cache presence check would look for a cache on the first task, never find > it and forces recaching. > > BUG=714934 > > Review-Url: https://codereview.chromium.org/2840463003 > Cr-Commit-Position: refs/heads/master@{#467114} > Committed: https://chromium.googlesource.com/chromium/src/+/755b1656f38d135013f24ddd8b6ec046874beed2 TBR=pfeldman@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=714934 Review-Url: https://codereview.chromium.org/2839083002 Cr-Commit-Position: refs/heads/master@{#467223}
darwin
added a commit
that referenced
this issue
Apr 26, 2017
578fd5a Revert of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2840463003/ ) b234267 DevTools: Base aggregated tree view percentage on the busy time. 6d225f3 DevTools: Fix timeline overview flickering 2f295d2 DevTools: update group-by combobox upon tree view change in timeline aggregated details. 4cc60e2 [DevTools] Move dom breakpoints to DOMDebuggerModel 5e52bda DevTools: fix aggregated donut chart cache population 85b5d4a [DevTools] Remove css_tracker left overs ca395f2 DevTools: trim the leading BOM char when parsing web manifest. 7b6b3d6 [DevTools] Consolidate overlay-related functionality in Overlay domain b344151 DevTools: Show screenshots on the main flamechart a70586d [DevTools] enable async stacks by default 193444d DevTools: compile_frontend.py accepts a pre-generated protocol externs file 24f4950 Revert of [DevTools] Consolidate overlay-related functionality in Overlay domain (patchset #7 id:120001 of https://codereview.chromium.org/2819183002/ ) git-subtree-dir: resources/unpacked/devtools git-subtree-split: 578fd5a
babot
pushed a commit
that referenced
this issue
Apr 29, 2017
…hset #1 id:1 of https://codereview.chromium.org/2839083002/ ) Reason for revert: The patch has noting to do with the failing test. In fact if you look at the flakiness dashboard the test is very flaky there: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Finspector%2Ftracing%2Ftimeline-js%2Ftimeline-runtime-stats.html Original issue's description: > Revert of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2840463003/ ) > > Reason for revert: > Suspected cause of failure of virtual/threaded/inspector/tracing/timeline-js/timeline-runtime-stats.html in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)/builds/9644 > > Original issue's description: > > DevTools: fix aggregated donut chart cache population > > > > The check for stats cache availablity was made on the first task in the main thread > > tasks list. If the first task happens to be filtered out, it never gets cache built for > > it. Later the cache presence check would look for a cache on the first task, never find > > it and forces recaching. > > > > BUG=714934 > > > > Review-Url: https://codereview.chromium.org/2840463003 > > Cr-Commit-Position: refs/heads/master@{#467114} > > Committed: https://chromium.googlesource.com/chromium/src/+/755b1656f38d135013f24ddd8b6ec046874beed2 > > TBR=pfeldman@chromium.org,alph@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=714934 > > Review-Url: https://codereview.chromium.org/2839083002 > Cr-Commit-Position: refs/heads/master@{#467223} > Committed: https://chromium.googlesource.com/chromium/src/+/65df576fce3007b62084239cc8e37a45aea0368f TBR=pfeldman@chromium.org,sashab@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=714934 Review-Url: https://codereview.chromium.org/2851823002 Cr-Commit-Position: refs/heads/master@{#468119}
darwin
added a commit
that referenced
this issue
Apr 29, 2017
30ad697 [Devtools] New structure and colorize rows for network products d46aaf6 [Devtools][Regression] Fixed websocket frame selection loss on frame received fb9c652 DevTools: Don't focus layers panel when it is shown ba54910 Reland of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2839083002/ ) ef9fa0f Revert of DevTools: Show screenshots on the main flamechart (patchset #3 id:40001 of https://codereview.chromium.org/2830343004/ ) a75caae [DevTools] Host paint profiles in PaintProfilerModel 97e8024 DevTools: clicking in console messages should not jump to bottom git-subtree-dir: resources/unpacked/devtools git-subtree-split: 30ad697
babot
pushed a commit
that referenced
this issue
Jun 17, 2017
…ilable (patchset #1 id:1 of https://codereview.chromium.org/2932703002/ ) Reason for revert: Fixed the original crash cause Original issue's description: > Revert of [DevTools] Show icon in top toolbar when Node target is available (patchset #3 id:40001 of https://codereview.chromium.org/2890973002/ ) > > Reason for revert: > See issue 727517 > > Original issue's description: > > [DevTools] Show icon in top toolbar when Node target is available > > > > Clicking on it opens dedicated Node frontend. > > > > BUG=706916 > > > > Review-Url: https://codereview.chromium.org/2890973002 > > Cr-Commit-Position: refs/heads/master@{#472739} > > Committed: https://chromium.googlesource.com/chromium/src/+/ad3ffab411cc396ffb20c1d35dcff6de038f14b4 > > TBR=pfeldman@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=706916 > > Review-Url: https://codereview.chromium.org/2932703002 > Cr-Commit-Position: refs/heads/master@{#478017} > Committed: https://chromium.googlesource.com/chromium/src/+/24309d877571d159bc14f871671ff0630d6f8d32 TBR=pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=706916,727517 Review-Url: https://codereview.chromium.org/2939173002 Cr-Commit-Position: refs/heads/master@{#479882}
darwin
added a commit
that referenced
this issue
Jun 19, 2017
c23ba78 DevTools: Turn inheritance into containment for PerfUI.ChartViewport 7c261a1 DevTools: stop whats new from opening on fresh profile 5eaaa75 [DevTools] Display usage & quota information 4c9ad6d [Devtools] Add contentData() and migrate tests away from .content 32b060a [Devtools] Stop using treeOutline for AX tree 48d8521 DevTools: fix stuck time scale in overview of Network and Timeline panels 0442011 Reland of [DevTools] Show icon in top toolbar when Node target is available (patchset #1 id:1 of https://codereview.chromium.org/2932703002/ ) 910881f DevTools: flip devtools extensions to load out of process. 276aea7 DevTools: roll the xterm.js to ToT. 36271b5 [DevTools] Clear console on GlobalObjectCleared git-subtree-dir: resources/unpacked/devtools git-subtree-split: c23ba78
babot
pushed a commit
that referenced
this issue
Jul 27, 2017
Fixes devtool's emulation of key input events to emulate os key event for OSX. Original CL: https://codereview.chromium.org/2656903005 Only major difference between two CLs is we now bypass browser if native_key_code was not set. 667387, 732053 Change-Id: If99f002491ef55caadbb7c82bcf55a2d1dbff8e6 Reviewed-on: https://chromium-review.googlesource.com/562583 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#489156}
darwin
added a commit
that referenced
this issue
Jul 27, 2017
55048a2 devtools: Add position:sticky constraint information to Layers panel 1eb8da0 DevTools: fix a regression in formatting nodes in console 1610881 Devtools: Support 8 (#RRGGBBAA) and 4 (#RGBA) value hex colors f5ce835 DevTools: fix capturing node screenshots without emulation. 2e6bc14 Show contrast ratio value on color picker when applicable. c86651f Revert "DevTools: treat similar console error-type parameters as equal" 59cb454 DevTools: treat similar console error-type parameters as equal 3cef172 DevTools: migrate some console tests to new integration test infrastructure 3976875 Move mixed content explanation calculation from DevTools to GetSecurityStyle(). 04ebb1c DevTools: Center toolbar icons. e606988 DevTools: make clip work without emulation. f96ee40 [Devtools] Added upload/download icon to websocket frames 59ae567 [Reland #1] ChromeDriver: Handle key events properly on Mac c2960a7 DevTools: prepare for new binary data subtypes 1bd15e3 DevTools: Add UMA for Audits2 e7f9c3c DevTools: [Audits] Roll Lighthouse 2.3.0 w/ dense report 52427ca DevTools: extract console_counters module git-subtree-dir: resources/unpacked/devtools git-subtree-split: 55048a2
babot
pushed a commit
that referenced
this issue
Jan 26, 2018
…mPoint" This reverts commit dd944882a245a5117b50cb417138d92f32d931d6. Reason for revert: This causes WebKit Linux Trusty ASAN buildbot failure. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN/builds/8618 23:46:29.565 3877 ==1==ERROR: AddressSanitizer: use-after-poison on address 0x7ead60c0dbf0 at pc 0x00000dca937a bp 0x7ffd86b90c10 sp 0x7ffd86b90c08 23:46:29.565 3877 READ of size 8 at 0x7ead60c0dbf0 thread T0 (content_shell) 23:46:29.565 3877 #0 0xdca9379 in operator==<const blink::TreeScope, const blink::TreeScope> third_party/WebKit/Source/platform/heap/Member.h:128:27 23:46:29.565 3877 #1 0xdca9379 in blink::TreeScope::Retarget(blink::Element const&) const third_party/WebKit/Source/core/dom/TreeScope.cpp:393:0 23:46:29.565 3877 #2 0xdca8894 in blink::TreeScope::HitTestPointInternal(blink::Node*) const third_party/WebKit/Source/core/dom/TreeScope.cpp:267:10 23:46:29.565 3877 #3 0xdca8325 in HitTestPoint third_party/WebKit/Source/core/dom/TreeScope.cpp:254:10 23:46:29.566 3877 #4 0xdca8325 in blink::TreeScope::ElementFromPoint(double, double) const third_party/WebKit/Source/core/dom/TreeScope.cpp:245:0 23:46:29.566 3877 #5 0xc9353a7 in elementFromPoint third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h:38:23 Original change's description: > Fix retargeting of result in elementFromPoint and elementsFromPoint > > Currently elementFromPoint and elementsFromPoint are not per spec, and it may > return null incorrectly. This change adds retargeting of the result with > respect to the context object, and adds some tests that are similar to > elementFromPoint tests in WebKit, but with some corrected cases: > https://git.webkit.org/?p=WebKit-https.git;a=blob;f=LayoutTests/fast/shadow-dom/DocumentOrShadowRoot-prototype-elementFromPoint.html;h=a8dc4da2430713521b9ba77c742db10397a8e638;hb=HEAD > > Spec: > https://w3c.github.io/webcomponents/spec/shadow/#extensions-to-the-documentorshadowroot-mixin > > Bug: 759947 > Change-Id: I6aece5e9cc826124772c6ce13c806865055b2b9b > Reviewed-on: https://chromium-review.googlesource.com/808446 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Hayato Ito <hayato@chromium.org> > Reviewed-by: Takayoshi Kochi <kochi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531139} TBR=kochi@chromium.org,dgozman@chromium.org,hayato@chromium.org,pfeldman@chromium.org,rakina@chromium.org Change-Id: Id62abd371d93627d3178b63ca189cecfe9ff44d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 759947 Reviewed-on: https://chromium-review.googlesource.com/880264 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#531178}
babot
pushed a commit
that referenced
this issue
Mar 13, 2019
Add a message telling users that storage quota is limited in Incognito mode (why: crbug 800329 comment \#1). In non-Incognito mode, the quota is in gigabytes. But in Incognito, the quota cap is no more than 120MB. Bug: 794269, 800329 Change-Id: Ic0d9e9d40119424c0b44bdd314d1f836af4ed357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506462 Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Reviewed-by: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#639677}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Similar to JSON display.
The text was updated successfully, but these errors were encountered: