Failing tests on master (Feb 28, 2014)

[nathany]

As per @yourewelcome's comment: #388 (comment) these need to be fixed before releasing a new version of the gem.

• test_deferred_error_message_translation the locale is being set but it's still returning the default error message
• test_validates_format_of_email_field_options_config message is expected to be a Proc but it's a String
• test_checks_password_against_database I think this is testing that the "new pass" doesn't persist?
• test_crypto_provider_config Authlogic::CryptoProviders::SCrypt expected but was
  Authlogic::CryptoProviders::Sha512.

I started looking into these but didn't get very far.

[binarylogic]

Thanks, I'll try to look some this week. Any help is appreciated.

[Hermanverschooten]

The test test_checks_password_against_database fails because it expects the crypto provider to be SCrypt but it is Sha512. I don't know enough of the code to see where this is set.

[Hermanverschooten]

These 2 PR fix all 4 errors.

[nathany]

Seeing this error on 3.4.0 when running tests:

ruby/2.1.1/gems/authlogic-3.4.0/lib/authlogic/crypto_providers/scrypt.rb:56:in `encrypt': uninitialized constant SCrypt (NameError)

[Hermanverschooten]

This seems to be resolved by @yourewelcome, the scrypt gem was added to the development dependencies. It is not added to the runtime dependencies, maybe it should, as this is now the default, see #400 too.