Fixes issues with Ruby 1.8.7, etc... #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uires active_record.
"should inherit alias scopes from superclasses" creates an anonymous subclass for its test. Anonymous classes return nil for .name by default. It passed in 1.9 because Searchlogic::ActiveRecord::Scope#scopes's monkey patched `include?` was inadvertantly calling .respond_to?(key) on `result` instead of the AR class. In 1.8.7, it resulted in a syntax error `unexpected '.', expecting kEND` in `.respond_to?(key)` because name was nil. So, instead of looking up the AR class by name, now a reference to the class is passed in.
compact_conditions "should remove conditions with blank values". In Ruby 1.9, Hash#select returns a hash, but in 1.8, it returns an array of key/value pair arrays.
…liasing scopes by symbol that have arguments.
oddlyzen
pushed a commit
that referenced
this pull request
Apr 24, 2012
Fixes issues with Ruby 1.8.7, etc...
|
@johndouthat Thanks for the work you put into this! We're actually currently working on a fork for Rails 3 compatibility. If you'd like to help out (and get a first look), ping me and we will keep you in the loop during the upgrade process. |
|
Hi Mark, Yeah, I'd love to help out and take a look. Thank You, Sent from my iPhone On Apr 24, 2012, at 2:04 PM, Mark Coatesreply@reply.github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you so much for Searchlogic. It's really great. I'm using it in several apps.
I'm going to try to work on Rails 3.2 compatibility in the near future, but for now I hope these changes help.