Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding navigation arrows to the cards in home section and solving the … #31

Closed
wants to merge 1 commit into from

Conversation

aasimtaif
Copy link

…issue no #24

@binbard
Copy link
Owner

binbard commented Oct 5, 2022

Fine. You could have just configured swiper settings instead of removing it.
This pr is messing up with mobile view (see sidebar login & cart)
See what can be done. Also sync current repo with your local before starting
Good luck 👍🏼

@binbard
Copy link
Owner

binbard commented Oct 6, 2022

Some issues:

  1. Irresponsive, weird cards alignment on mobile screen.
  2. Not auto slide auto play
  3. No pagination
    Also you removed swiper. Dunno why

@binbard binbard added the check label Oct 6, 2022
@binbard binbard changed the title Adding navigation arrows to the cards in home sectionand solving the … Adding navigation arrows to the cards in home section and solving the … Oct 7, 2022
@binbard binbard self-requested a review October 7, 2022 18:25
@binbard
Copy link
Owner

binbard commented Oct 7, 2022

You are working on previous version of this repo. Please update it and then work.
Also you aren't adding something, just removing swiper and implementing another carousel
I think current is navbar by swiperjs is not having an issue
So I'm closing this

@binbard binbard closed this Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding navigation arrows to the cards in home section.
2 participants