Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BB-242] _load_configs_for_credentials test #245

Merged
merged 6 commits into from
Feb 20, 2024
Merged

[BB-242] _load_configs_for_credentials test #245

merged 6 commits into from
Feb 20, 2024

Conversation

Franr
Copy link
Contributor

@Franr Franr commented Feb 10, 2024 •
edited
Loading

What?

  • Adding unit tests for _load_configs_for_credentials
  • Introducing coveralls.io, a way to track coverage over our tests.

Why?

References

#232

@Franr Franr marked this pull request as ready for review February 18, 2024 14:14
@Franr Franr requested review from a team February 19, 2024 18:02
@Franr Franr self-assigned this Feb 19, 2024
@exequielrafaela exequielrafaela added enhancement New feature or request patch labels Feb 19, 2024
@Franr Franr merged commit 8055a71 into master Feb 20, 2024
13 checks passed
@Franr Franr deleted the load_config_credentials_tests branch February 20, 2024 11:45
@exequielrafaela exequielrafaela mentioned this pull request Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exequielrafaela exequielrafaela exequielrafaela approved these changes

@diego-ojeda-binbash diego-ojeda-binbash diego-ojeda-binbash approved these changes

Assignees

@Franr Franr

Labels
enhancement New feature or request patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Franr @exequielrafaela @diego-ojeda-binbash