Cleanup patches #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added dummy _stop/_child methods to avoid warnings.
…leanup. If a event callback was used, and the external session called write/send/close, the wheel was beeing worked on from the wrong session. For regular write this was not a problem, but when registering the FlushedEvent, the 'shutdown' event was sent to the wrong session. This yielded a non-free'ed wheel. Also forcibly remove circual references on cleanup, DESTROY get's called as it should now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've patched the FastCGI PoCo a bit, mainly two changes:
More details are in the commit msgs. Noticed the session-thing when I ran my app with options => {default => 1} (which I usually always do).
Please take a look at them and if you think they're good, please push to CPAN repo.
Cheers
Johan