Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc upperdir fixes #169

Merged
merged 8 commits into from
Aug 22, 2024
Merged

misc upperdir fixes #169

merged 8 commits into from
Aug 22, 2024

Conversation

ezrizhu
Copy link
Collaborator

@ezrizhu ezrizhu commented Jul 13, 2024

some of the pure_mountpoint logic were missed when merging commits over. this PR addresses them by copying those changes from the hs branch.

@ezrizhu ezrizhu self-assigned this Jul 13, 2024
@ezrizhu ezrizhu requested a review from mgree July 16, 2024 06:16
Copy link
Contributor

@mgree mgree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is adding new behavior, can we add a testcase for it?

try Show resolved Hide resolved
@ezrizhu ezrizhu requested a review from mgree August 18, 2024 03:03
test/merge_multiple_dirs.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@mgree mgree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please write a commit message for the squashed commit that summarizes things neatly!

@ezrizhu ezrizhu merged commit b670fcf into main Aug 22, 2024
21 checks passed
@ezrizhu ezrizhu deleted the misc-upperdir-fix branch August 22, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants