Improve "Skipping" log message of bintrayUpload task. #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reporting this @artem-zinnatullin. |
|
Done. I've noticed that you don't have public CI in this repo, hadn't I broke Groovy string formatting? (I made PR right on GitHub) |
philandstuff
added a commit
to alphagov/gds_metrics_dropwizard
that referenced
this pull request
Sep 7, 2018
To pull in better feedback such as bintray/gradle-bintray-plugin#175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just spent an hour trying to understand why my project was not uploading to bintray, turned out I made a typo in env variable name that was passing api key.
Had to read gradle-bintray-plugin sources and found out that message:
Was actually meaning that
bintrayUploadtask will be skipped inmyModule!So I specified the reason and made task format more similar to what Gradle usually outputs i.e.: