Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc keepalive config #242

Merged
merged 3 commits into from
Jan 15, 2020
Merged

Add grpc keepalive config #242

merged 3 commits into from
Jan 15, 2020

Conversation

taktv6
Copy link
Member

@taktv6 taktv6 commented Jan 14, 2020

No description provided.

@taktv6 taktv6 requested a review from hikhvar January 14, 2020 19:04
@codecov-io
Copy link

Codecov Report

Merging #242 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   59.15%   59.15%           
=======================================
  Files         137      137           
  Lines        7423     7423           
=======================================
  Hits         4391     4391           
  Misses       2853     2853           
  Partials      179      179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3130c33...eb1f84c. Read the comment docs.

Copy link
Contributor

@hikhvar hikhvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires every RIS client to use also the google.golang.org/grpc/keepalive library?

LGTM.

@hikhvar hikhvar merged commit ece9aa0 into master Jan 15, 2020
@taktv6 taktv6 deleted the ris/keepalive branch April 12, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants