Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-Path Support for IPv6 #96

Merged
merged 21 commits into from
Jul 24, 2018
Merged

Add-Path Support for IPv6 #96

merged 21 commits into from
Jul 24, 2018

Conversation

czerwonk
Copy link
Member

@czerwonk czerwonk commented Jul 13, 2018

resolves #96

@czerwonk czerwonk requested a review from taktv6 July 13, 2018 19:56
@coveralls
Copy link

coveralls commented Jul 13, 2018

Pull Request Test Coverage Report for Build 771

  • 159 of 205 (77.56%) changed or added relevant lines in 15 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 70.973%

Changes Missing Coverage Covered Lines Changed/Added Lines %
protocols/bgp/server/update_sender.go 61 62 98.39%
protocols/bgp/packet/update.go 3 4 75.0%
protocols/bgp/server/fsm_address_family.go 16 18 88.89%
protocols/bgp/server/fsm.go 12 16 75.0%
protocols/bgp/packet/bgp.go 4 8 50.0%
protocols/bgp/server/fsm_open_confirm.go 0 5 0.0%
protocols/bgp/server/peer.go 25 33 75.76%
protocols/bgp/server/fsm_open_sent.go 1 22 4.55%
Files with Coverage Reduction New Missed Lines %
protocols/bgp/server/update_sender.go 2 87.39%
protocols/bgp/server/fsm_open_sent.go 2 16.67%
Totals Coverage Status
Change from base Build 765: 0.3%
Covered Lines: 3604
Relevant Lines: 5078

💛 - Coveralls

@czerwonk czerwonk changed the title Add-Path Support for IPv6 WIP: Add-Path Support for IPv6 Jul 16, 2018
This was referenced Jul 17, 2018
@czerwonk czerwonk changed the title WIP: Add-Path Support for IPv6 Add-Path Support for IPv6 Jul 18, 2018
Copy link
Member

@taktv6 taktv6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taktv6 taktv6 merged commit e5856a5 into master Jul 24, 2018
@czerwonk czerwonk deleted the feature/ipv6_addpath_tx branch July 24, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants