-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.2.3 #13
Merged
Merged
Version 0.2.3 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github Actions succeeded
Test PR closes #4
Last checks and documentation updates before CRAN submission Sent for review
formulas in documentation for getAlphaMetrics + code formatting
BTsubset_meta and BTsubset_data
no more redundancy but the vignette breaks
Please do not start the description with "This package", package name, title or similar. Please always write package names, software names and API (application programming interface) names in single quotes in title and description. e.g: --> 'BioTIMEr' Please note that package names are case sensitive. Unless "gridding" is a package name or software name, please remove the sinlge quotes '...' around it.
Please add \value to .Rd files regarding exported methods and explain the functions results in the documentation. Please write about the structure of the output (class) and also what the output means. (If a function does not return a value, please document that too, e.g. \value{No return value, called for side effects} or similar) -> Warning: Missing Rd-tags: BioTIME-palette.Rd: \value
-> Warning: Examples for unexported function BioTIMEr-package() in: getAlpha.Rd BTsubset_data() in: getBeta.Rd getBeta() in: rarefysamples.Rd
\dontrun{} should only be used if the example really cannot be executed (e.g. because of missing additional software, missing API keys, ...) by the user. That's why wrapping examples in \dontrun{} adds the comment ("# Not run:") as a warning for the user. Please replace \dontrun with \donttest where possible. Please unwrap the examples if they are executable in < 5 sec, or replace dontrun{} with \donttest{}.
\dontrun{} should only be used if the example really cannot be executed (e.g. because of missing additional software, missing API keys, ...) by the user. That's why wrapping examples in \dontrun{} adds the comment ("# Not run:") as a warning for the user. Please replace \dontrun with \donttest where possible. Please unwrap the examples if they are executable in < 5 sec, or replace dontrun{} with \donttest{}.
\dontrun{} should only be used if the example really cannot be executed (e.g. because of missing additional software, missing API keys, ...) by the user. That's why wrapping examples in \dontrun{} adds the comment ("# Not run:") as a warning for the user. Please replace \dontrun with \donttest where possible. Please unwrap the examples if they are executable in < 5 sec, or replace dontrun{} with \donttest{}. Left the example for the internal rarefysample for future work on the functions
Malformed markdown
the dependency on dggridr was changed from CRAN to @SebKrantz github fork
Signed-off-by: AlbanSagouis <alban.sagouis@idiv.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.