Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for gzipped fastq #28

Merged
merged 2 commits into from Mar 21, 2017
Merged

check for gzipped fastq #28

merged 2 commits into from Mar 21, 2017

Conversation

pbelmann
Copy link
Member

@pbelmann pbelmann commented Mar 20, 2017 •
edited

michaelbarton
michaelbarton approved these changes Mar 20, 2017
View reviewed changes
Copy link
Contributor

@michaelbarton michaelbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Peter. Thanks for adding this functionality along with tests. I think this will make it much easier when users get the correct error message if they submit data not in gzip format.

@pbelmann pbelmann merged commit d77f646 into master Mar 21, 2017
@pbelmann pbelmann deleted the feature/check-for-gzipped-fastq branch March 21, 2017 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbarton michaelbarton michaelbarton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pbelmann @michaelbarton