added basic epa-ng recipe #10902
added basic epa-ng recipe #10902
Conversation
gavinmdouglas
commented
Sep 11, 2018
gavinmdouglas
commented
- I have read the guidelines for bioconda recipes.
- This PR adds a new recipe.
- AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
- This PR updates an existing recipe.
- This PR does something else (explain below).
Fix build for epa-ng recipe (on bioconda-docker at least)
recipes/epa-ng/meta.yaml
Outdated
| - cmake==3.11 | ||
| - automake | ||
| - autoconf | ||
| run: |
There was a problem hiding this comment.
zlib should be a host dependency. The run dependency will be injected automatically.
There was a problem hiding this comment.
The build/host/run is a little confusing. It's for cross compiling. Everything that is build machinery, so compiler and build tools go into build. Everything that is dependent on the build target, so libraries you need to link against, goes into host. Things that will be needed at run time go in to run. Some packages have what conda calls run exports. Those will add things to your run automatically. Zlib is one of them. The run: - zlib is therefore redundant.
There was a problem hiding this comment.
Yes I was confused by this; however, without adding zlib as a run requirement this error arises: SERR epa-ng: error while loading shared libraries: libz.so.1: cannot open shared object file: No such file or directory, which you can see here: https://circleci.com/gh/bioconda/bioconda-recipes/38521?utm_campaign=workflow-failed&utm_medium=email&utm_source=notification
|
|
||
| about: | ||
| home: https://github.com/Pbdas/epa-ng | ||
| license: GNU Affero General Public License v3.0 |
There was a problem hiding this comment.
GPL requires that the license be distributed with the packages. Please add license_file:
There was a problem hiding this comment.
Sorry I'm unsure what you mean by this. The LICENSE file is packaged with the source. Should I specify license_file: LICENSE?
There was a problem hiding this comment.
Yes. It needs to be distributed with the binaries as well. By specifying license_file: LICENSE conda-build knows which file to add to the package (ends up in the info folder).
There was a problem hiding this comment.
Ok thanks - I added it
|
Hi @epruesse, it looks like all of the minor edits have been addressed. |
|
Thanks for your help @epruesse. |
