Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build bowtie on macOS ARM #49326

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Build bowtie on macOS ARM #49326

merged 4 commits into from
Jul 17, 2024

Conversation

akikuno
Copy link
Contributor

@akikuno akikuno commented Jul 17, 2024

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@akikuno
Copy link
Contributor Author

akikuno commented Jul 17, 2024

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Jul 17, 2024
@corneliusroemer corneliusroemer added the osx-arm64 Related to adding osx-arm64 support label Jul 17, 2024
recipes/bowtie/build.sh Show resolved Hide resolved
recipes/bowtie/build.sh Outdated Show resolved Hide resolved
recipes/bowtie/build.sh Outdated Show resolved Hide resolved
@@ -1,5 +1,9 @@
#!/bin/bash

if [ "$(uname -m)" == "arm64" ]; then
make POPCNT_CAPABILITY=0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a brief comment on why POPCNT_CAPABILITY needs to be disabled for arm64 only would be great!

Copy link
Contributor Author

@akikuno akikuno Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corneliusroemer
I've added a comment about it. Thank you!

3f76ecf

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martin-g martin-g merged commit 650fcd5 into bioconda:master Jul 17, 2024
6 checks passed
@akikuno akikuno deleted the bowtie-32376 branch July 17, 2024 08:23
tcezard pushed a commit to tcezard/bioconda-recipes that referenced this pull request Sep 12, 2024
* Build bowtie on macOS ARM

* Use parallel build with `make`

* Add a comment of why POPCNT_CAPABILITY needs to be disabled for arm64 only

* Update recipes/bowtie/build.sh

---------

Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
Co-authored-by: Cornelius Roemer <cornelius.roemer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
osx-arm64 Related to adding osx-arm64 support please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants