Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive checking for value section in Rd files #189

Closed
grimbough opened this issue Apr 5, 2023 · 2 comments
Closed

False positive checking for value section in Rd files #189

grimbough opened this issue Apr 5, 2023 · 2 comments

Comments

@grimbough
Copy link
Contributor

Hi @LiNk-NY

I think the recent changes for checking return sections in Rd files might be triggering a false positive. Specifically I'm thinking of man pages that document the package itself, which I wouldn't expect to have a return section.

These are described in r-pkgs.org and I have a specific example in Rarr which is now triggering a warning in BiocCheck when it did not in the past.

If you agree it's a false positive, I wonder if you can use BiocCheck:::docType(rd) == "package" somewhere to test for this scenario.

Cheers,
Mike

@LiNk-NY
Copy link
Contributor

LiNk-NY commented Apr 6, 2023

Thanks for reporting. It should be resolved in ad4d1c8

@LiNk-NY LiNk-NY closed this as completed Apr 6, 2023
@grimbough
Copy link
Contributor Author

Awesome, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants