Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sidebar for listing errors and warnings #7

Closed
jairideout opened this issue Sep 6, 2014 · 3 comments
Closed

add sidebar for listing errors and warnings #7

jairideout opened this issue Sep 6, 2014 · 3 comments
Assignees
@jairideout
Labels
enhancement
Milestone
Additional format...

Comments

@jairideout
Copy link
Member

Adding a sidebar that lists the various errors and warnings would be really helpful for larger spreadsheets where it's hard to find all problems simply by looking at the cells. See the sidebar documentation. Would be awesome if clicking an error/warning focused on the offending cell in the spreadsheet.
@jairideout
Copy link
Member Author

@ElDeveloper recommended having some sort of persistence to the sidebar in case the user validates their sheet, closes it, then reopens it (e.g., the log should stick around so they don't have to rerun the validator).

@jairideout jairideout added this to the Additional formats and GUI improvements (alpha) milestone Apr 17, 2015
@jairideout jairideout self-assigned this Dec 29, 2015
jairideout added a commit that referenced this issue Dec 30, 2015
@jairideout
MAINT: refactor to separate model and view logic
7e13d9a 
Validators no longer take state as input and instead return info about invalid cells. Results from validators are combined to form the model, which can be rendered by views. There is currently only one view (SheetView) for rendering validation results in the Google Sheet itself (i.e., coloring cells and using notes to display validation messages).

This new factoring was necessary for #7 and #8. There are also minor performance gains due to fewer API calls (mainly because validators accept a value->positions mapping instead of recomputing in each validator).

Fixes #26.
@jairideout
Copy link
Member Author

This is now possible after the refactoring in 7e13d9a.

@jairideout jairideout mentioned this issue Jan 8, 2016
Open
@jairideout
Copy link
Member Author

Moved the sidebar persistence request (comment here) to #60.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jairideout jairideout

Labels
enhancement
Projects
None yet
Milestone
Additional formats and GUI improvemen...
Development

No branches or pull requests
1 participant
@jairideout