Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable plating interface until at least one study is selected #577

Open
fedarko opened this issue Aug 21, 2019 · 2 comments
Open

Disable plating interface until at least one study is selected #577

fedarko opened this issue Aug 21, 2019 · 2 comments
Assignees

Comments

@fedarko
Copy link
Collaborator

fedarko commented Aug 21, 2019

Based on discussion with @charles-cowart.

@AmandaBirmingham
Copy link
Collaborator

I agree that 99% of the time (ok, probably 99.9% of the time ...) users will want to plate actual samples. However, it is entirely possible for them to make and run plates that contain nothing but some combination of blanks, negative controls, and positive controls--none of which require a study. Therefore I do not think we can require them to pick a study before letting them plate. We could, maybe, ask them if they really want to continue without picking a study--that would probably be an acceptable level of nagging, given how infrequently they will probably legitimately want to do a no-study plate. Thoughts?

@fedarko
Copy link
Collaborator Author

fedarko commented Sep 10, 2019

I wasn't aware that was a use case, but I can understand how that'd happen! Agreed that we should definitely allow users to plate without a study, then.

As I remember, the main reason Charlie and I started talking about this issue was #568—currently, if you start plating things then select a study, the already-plated wells don't update and it looks wonky. If we make sure that #568 is properly accounted for, I'm ok with not going ahead with this (or at least delegating to the asking-for-confirmation-before-plating-without-a-study idea).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants