Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should we contribute to bioconda instead of maintaining this project on our own? #62

Open
gregcaporaso opened this issue Mar 2, 2016 · 13 comments

Comments

@gregcaporaso
Copy link

There is some discussion of this in #61 (ping @wasade, as he brought this up there). I think we should investigate ending this project in favor of contributing to bioconda. Thoughts on this?

@jairideout did a little research into bioconda and found that they're funded by continuum, and have a bunch of the same packages that we have here, including QIIME and vsearch.

@ElDeveloper
Copy link
Member

👍 this makes perfect sense!

Yoshiki Vázquez-Baeza

On Mar 2, 2016, at 12:31 PM, Greg Caporaso notifications@github.com wrote:

There is some discussion of this in #61 (ping @wasade, as he brought this up there). I think we should investigate ending this project in favor of contributing to bioconda. Thoughts on this?

@jairideout did a little research into bioconda and found that they're funded by continuum, and have a bunch of the same packages that we have here, including QIIME and vsearch.


Reply to this email directly or view it on GitHub.

@wasade
Copy link
Member

wasade commented Mar 2, 2016

👍

On Wed, Mar 2, 2016 at 12:31 PM, Greg Caporaso notifications@github.com
wrote:

There is some discussion of this in #61
#61 (ping @wasade
https://github.com/wasade, as he brought this up there). I think we
should investigate ending this project in favor of contributing to
bioconda. Thoughts on this?

@jairideout https://github.com/jairideout did a little research into
bioconda and found that they're funded by continuum, and have a bunch of
the same packages that we have here, including QIIME and vsearch.


Reply to this email directly or view it on GitHub
#62.

@colinbrislawn
Copy link
Contributor

Great question. We want to contribute to standard projects and avoid duplicate work.

Let's see how quickly these qiime PRs get excepted. If the bioconda devs are responsive, let's contribute over there.

@colinbrislawn
Copy link
Contributor

colinbrislawn commented Mar 25, 2016

These packages have been successfully added to Bioconda.
(Not all offer cross platform support.
Some are not up to date.
Some do not have right version for qiime.)

  • ARAGORN
  • Diamond
  • FastTree
  • HMMER
  • Infernal
  • MAFFT
  • MinCED
  • Prodigal
  • SortMeRNA
  • VSEARCH
  • blastlegacy
  • blastplus
  • micronota
  • rdp-tools
  • swarm

@sjanssen2
Copy link
Collaborator

I compared biocores recipes with what is available in bioconda and found the following:

These packages are in bioconda, sometimes with a newer version than available on biocore:

  • Diamond (newer verison available)
  • ARAGORN (same version)
  • fasttree (same version)
  • HMMER (same version)
  • infernal (newer version available)
  • mafft (newer version available)
  • minced (same version)
  • prodigal (newer version available)
  • transtermhp (same version)
  • vsearch (newer version available)
  • blastplus (blast on bioconda is newer)
  • rdp-tools (same version, but called "rdptools")
  • swarm (newer version available)

Bioconda not yet has those recipes, we should think about migrating them to bioconda:

  • blastlegacy (keep since we have better conda magic)
  • sortmerna (keep since bioconda seems to use this one)
  • disopred (missing in bioconda)
  • memsat-svm (missing in bioconda)
  • psipred (missing in bioconda)

I would say we should keep the following recipes in biocore since they are under our development and somehow in flux:

  • biom-format (our version is newer)
  • deblur (missing in bioconda)
  • gneiss (missing in bioconda)
  • micronota (missing in bioconda)
  • q2-deblur (missing in bioconda)

In general, we have the issue that the basic libc on barnacle is somewhat outdated and pre-compiled binaries (like those installed via conda) might require a later version. We should be able to work around that issue by downloading the affected conda recipe from bioconda, compile i.e. conda build the package on barnacle, and upload the build to biocore.

What do you think about removing the above listed duplicated recipes in a first step?
@gregcaporaso @ElDeveloper @wasade @RNAer @mortonjt @Jorge-C @colinbrislawn @ekopylova

@colinbrislawn
Copy link
Contributor

colinbrislawn commented Sep 28, 2017

What do you think about removing the above listed duplicated recipes in a first step?

I like this. I feel like our conda-recipes should be for our own software, or quirky dependencies that our software needs.

Edit:
On the other hand, bioconda is massive. They have more than 2000 recipes, a packed built queue, and frequent updates to their build platform. Our little conda channel is easy to maintain.

@ElDeveloper
Copy link
Member

ElDeveloper commented Sep 28, 2017 via email

@sjanssen2
Copy link
Collaborator

@ElDeveloper are our tools within the cope of conda-forge?
Shall we start by removing those recipes that are already bioconda? That might help solving the current build fails on the master branch.

@ElDeveloper
Copy link
Member

ElDeveloper commented Sep 29, 2017 via email

@sjanssen2
Copy link
Collaborator

hm, how would you test equivalency if version numbers differ?

@ElDeveloper
Copy link
Member

ElDeveloper commented Sep 29, 2017 via email

@sjanssen2
Copy link
Collaborator

and you think that all those software packages comes with unit tests?! In principle, conda's meta.yaml allows for a test section, but in most recipes I saw so far, the only test is printing the help/usage message, i.e. not a real test.

@ElDeveloper
Copy link
Member

ElDeveloper commented Sep 29, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants