Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with long metadata category names #259

Merged
merged 4 commits into from
Apr 21, 2014

Conversation

ElDeveloper
Copy link
Member

Changed the style to only use the available space inside the tab and nothing
more i. e. there won't be x-axis scroll bars if the category name doesn't fit
inside the tab.

Fixes #246

This styling will fix the problems that would occurr when category names
were too long for the tab to be displayed, resulting in a mal-formed
layout.

Fixes biocore#246
About resolving the problem with long category names.
@emperor-helper
Copy link

The test build for this pull request can be found here: http://emperor.colorado.edu/pull_259/make_emperor/

@antgonza
Copy link
Collaborator

These changes to the code look fine but I do not think we have a GUI
test for this case (i.e.
http://emperor.colorado.edu/pull_259/make_emperor/), could you add
one? Thank you.

@ElDeveloper
Copy link
Member Author

No problem. I've added a long header name to Fasting_Map_modified.txt, so the examples that use that mapping file, should have that.

On Apr 21, 2014, at 6:47 AM, Antonio Gonzalez notifications@github.com wrote:

These changes to the code look fine but I do not think we have a GUI
test for this case (i.e.
http://emperor.colorado.edu/pull_259/make_emperor/), could you add
one? Thank you.

Reply to this email directly or view it on GitHub.

@ElDeveloper
Copy link
Member Author

Tests should be passing now.

antgonza added a commit that referenced this pull request Apr 21, 2014
Fix problem with long metadata category names
@antgonza antgonza merged commit 29aa3e8 into biocore:master Apr 21, 2014
@ElDeveloper
Copy link
Member Author

Thanks @antgonza!

On Apr 21, 2014, at 1:11 PM, Antonio Gonzalez notifications@github.com wrote:

Merged #259.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants