BUG: Fix problem with --color_by #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When nothing was passed in to --color_by, the default behaviour was to keep all the columns in the mapping file. This was inconsistent with the documented behavior, to remove unique columns, which has now been corrected. See the comments in this patch. Fixes biocore#271
|
The test build for this pull request can be found here: http://emperor.colorado.edu/pull_306/make_emperor/ |
|
Using the mice tutorial --add_unique_columns doesn't work as expected, it |
Conflicts: ChangeLog.md
|
Thanks for catching that, I'm working on this right now. |
If we requested the unique columns to be kept, then only the SampleID would be retained, which was in turn useless. This has been fixed.
|
Should be fixed ... waiting for the tests to pass. |
|
Now using or not --add_unique_columns gives the same output. |
If you didn't pass anything with -b you would get all the categories, whilst if you passed --add_unique_columns you would get only SampleID. This has been fixed for good. 🐛
|
This time it should be fixed for good. |
|
Finally!!! |
antgonza
added a commit
that referenced
this pull request
Sep 24, 2014
BUG: Fix problem with --color_by
|
Thanks for reviewing @antgonza. On (Sep-24-14| 7:48), Antonio Gonzalez wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a category was passed in with the --color_by flag and the values in the
mapping file were unique, this category was removed; this problem has now been
fixed a new test case was added and a note in the ChangeLog.md was re-added.
See #271