Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--color_by should allow coloring by categories where all values are different #271

Closed
gregcaporaso opened this issue May 19, 2014 · 1 comment
Closed

--color_by should allow coloring by categories where all values are different #271

gregcaporaso opened this issue May 19, 2014 · 1 comment
Assignees
@ElDeveloper
Labels
CLI
Milestone
Emperor 0.9.5

Comments

@gregcaporaso
Copy link
Contributor

if the user specifies a category to color by, it always should be (currently if all values in a category are different it doesn't work)
@gregcaporaso
Copy link
Contributor Author

Just saw --add_unique_columns, so it's possible to do what I want to do, but I still think it might make sense for this default behavior to be overridden by --color_by.

@ElDeveloper ElDeveloper added this to the Emperor 0.9.4 milestone Sep 3, 2014
@ElDeveloper ElDeveloper self-assigned this Sep 3, 2014
ElDeveloper added a commit to ElDeveloper/emperor that referenced this issue Sep 5, 2014
@ElDeveloper
BUG: Fix problem with unique/single valued-columns
bc0b27d 
If a category in the mapping file had a unique/single valued column,
this would automatically be removed regardless of the fact that the user
could have asked to keep the column. Some tests were fixed to reflect
the case they were checking.

Fixes biocore#271
ElDeveloper added a commit to ElDeveloper/emperor that referenced this issue Sep 5, 2014
@ElDeveloper
TST: Add three more test cases related to biocore#271
fa232fd
ElDeveloper added a commit to ElDeveloper/emperor that referenced this issue Sep 6, 2014
@ElDeveloper
DOC: Add note about the fix of biocore#271
76da557
@ElDeveloper ElDeveloper mentioned this issue Sep 6, 2014
Merged
antgonza added a commit that referenced this issue Sep 6, 2014
@antgonza
Merge pull request #291 from ElDeveloper/issue-271
b24492e 
BUG: Fix issue #271
ElDeveloper added a commit that referenced this issue Sep 10, 2014
@ElDeveloper
Revert "BUG: Fix issue #271"
8c82556
@ElDeveloper ElDeveloper removed this from the Emperor 0.9.4 milestone Sep 10, 2014
@ElDeveloper ElDeveloper reopened this Sep 10, 2014
antgonza added a commit that referenced this issue Sep 10, 2014
@antgonza
Merge pull request #296 from biocore/revert-291-issue-271
4cccca8 
Revert "BUG: Fix issue #271"
@ElDeveloper ElDeveloper added this to the Emperor 0.9.5 milestone Sep 11, 2014
ElDeveloper added a commit to ElDeveloper/emperor that referenced this issue Sep 22, 2014
@ElDeveloper
DOC: Add documentation about fixing biocore#271
f9880e2
@ElDeveloper ElDeveloper mentioned this issue Sep 22, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElDeveloper ElDeveloper

Labels
CLI
Projects
None yet
Milestone
Emperor 0.9.5
Development

No branches or pull requests
2 participants
@gregcaporaso @ElDeveloper