Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse utils #253

Merged
merged 30 commits into from Jun 11, 2018
Merged

Sparse utils #253

merged 30 commits into from Jun 11, 2018

Conversation

mortonjt
Copy link
Collaborator

@mortonjt mortonjt commented Feb 12, 2018

This adds support for sparse data manipulation, namely

  • Aligning trees against biom tables
  • Sparse indexing of dense matrix multiplication
  • Minibatch selection

Depends on #250

@mortonjt
Copy link
Collaborator Author

There are some really weird errors going on with nose, making it difficult to get this functionality in.
@antgonza , @ElDeveloper any idea what is going on? I'm able to produce this on my laptop, but not sure why nose is behaving this way.

@ElDeveloper
Copy link
Member

From the looks of the travis output, the problem does not seem to be coming from nose, it seems to becoming from the coverage tool. It appears to be interpreting that --with-doctest is an argument for setup.py. Later on setup.py errors as that's not an available option. I would try changing the makefile to enclose nose --with-doctest in single-quotes or use a double-hyphen to separate the positional arguments i.e ..... setup.py -- nose --with-doctest. If that doesn't work then I don't have any other ideas. ¯\_(ツ)_/¯

self.assertEqual(str(tree), u"(((a,b)f,c),d)r;\n")


class TestUtil(unittest.main):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derp found the bug. Thanks @antgonza for helping me find this.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 96.193% when pulling 7798aa1 on mortonjt:sparse-utils into 52edad9 on biocore:master.

@mortonjt
Copy link
Collaborator Author

mortonjt commented Jun 1, 2018

Alright - it looks like the tests are passing. If there aren't any issues with this PR, I'll be merging this in over the next few days.

What do you think @antgonza ?

@antgonza
Copy link
Contributor

antgonza commented Jun 1, 2018

Wanna add test so the coverage doesn't decrease?

@mortonjt
Copy link
Collaborator Author

mortonjt commented Jun 7, 2018

@antgonza thanks for catching that -- there were actually a couple of nasty bugs that would have slipped through if it weren't for that test. It should be ok now.

@antgonza
Copy link
Contributor

antgonza commented Jun 8, 2018

Kewl, any idea why coveralls didn't run this time?

@mortonjt
Copy link
Collaborator Author

mortonjt commented Jun 8, 2018 via email

@antgonza antgonza merged commit cb6f336 into biocore:master Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants