-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparse utils #253
Sparse utils #253
Conversation
There are some really weird errors going on with nose, making it difficult to get this functionality in. |
From the looks of the travis output, the problem does not seem to be coming from nose, it seems to becoming from the coverage tool. It appears to be interpreting that |
gneiss/tests/test_util.py
Outdated
self.assertEqual(str(tree), u"(((a,b)f,c),d)r;\n") | ||
|
||
|
||
class TestUtil(unittest.main): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
derp found the bug. Thanks @antgonza for helping me find this.
Alright - it looks like the tests are passing. If there aren't any issues with this PR, I'll be merging this in over the next few days. What do you think @antgonza ? |
Wanna add test so the coverage doesn't decrease? |
@antgonza thanks for catching that -- there were actually a couple of nasty bugs that would have slipped through if it weren't for that test. It should be ok now. |
Kewl, any idea why coveralls didn't run this time? |
That's strange. Let's restart it
…On Thu, Jun 7, 2018, 6:12 PM Antonio Gonzalez ***@***.***> wrote:
Kewl, any idea why coveralls didn't run this time?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#253 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AD_a3Zfj6P0jC5P3A8rT_9iQXQtCUkHQks5t6c9xgaJpZM4SCy1M>
.
|
This adds support for sparse data manipulation, namely
Depends on #250