Statsmodels interface #39
Conversation
ENH: Adding in first draft of the RegressionResults object
Regression results part2
…into regression_results_part3
|
Does this need to be review/merged? |
|
A review would be great! |
| feature_names=table.columns) | ||
|
|
||
|
|
||
| def mixedlm(formula, table, metadata, tree, groups, **kwargs): |
There was a problem hiding this comment.
just curious, isn't this method basically the same as the ols() method short of the specific method executed under the smf namespace?
There was a problem hiding this comment.
Yes and no.
The idea was to provide the same sort of interface to the user, so that they can easily swap methods in and out.
The only difference between mixedlm and ols from an API point of view is that mixedlm has an required argument groups.
|
Don't merge just yet I just realized that I need to throw a ValueError in case there are zeros in the data. |
| for r in self.results: | ||
| p = r.pvalues | ||
| p.name = r.model.endog_names | ||
| self.pvalues = self.pvalues.append(p) |
There was a problem hiding this comment.
from what I can tell no
http://pandas.pydata.org/pandas-docs/stable/generated/pandas.DataFrame.append.html
|
👍 |
Adding more documentation explaining ols and mixedlm Addressing @wasade's comments
|
Ok. All comments have been addressed. Note that I've forced the scikit-bio dependency to be 0.4.2, since there is an issue with shear/prune in 0.5.0. I'll raise a detailed bug report once this PR is merged. |
…into regression_results
|
The changelog has been updated. This is ready for final review/merge. Note that this is the last major change before the alpha release. |
| @@ -1,9 +1,15 @@ | |||
| # gneiss changelog | |||
| ## Version 0.1.0 (changes since 0.1.0 go here) | |||
There was a problem hiding this comment.
If you are tagging the repo as of the merge of this PR, then it may make more sense to remove these two lines, and (below) update the "Version 0.0.2 (changes since 0.0.2 go here)" to "Version 0.0.2".
|
Looks good to me overall 👍 |
|
Sweet! |
|
Can we merge this? |
This is picking up from #22
This basically sums up all of the PRs that have been reviewed so far.
The last thing that needs to happen here is the IPython notebooks need to be rebuilt with the existing code. I'll let you guys know when that is ready.