This repository has been archived by the owner on Nov 9, 2023. It is now read-only.
Fixes issue #711 #741
Merged
Fixes issue #711 #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the defaults as @gregcaporaso suggested so that if a depth is not passed it will use the deepest available. Updated the documentation in the script and library and added a test.
| "The following command runs a parametric two sample t-test using the " | ||
| "t-distribution instead of Monte Carlo permutations at the greatest depth available.", | ||
| "%prog -i PD_whole_tree.txt -m mapping.txt -c Treatment -o " | ||
| "PD_d100_parametric.txt -t parametric")) |
There was a problem hiding this comment.
For clarity, could you name this output file PD_dmax_parametric.txt, or something like that?
|
Thanks @wdwvt1! Just a couple of comments to address before merge. |
|
Sorry about missing the test there -- that was stupid. I have updated it the test to be both correct and actually called. |
|
Thanks @wdwvt1! This is a really useful fix! |
gregcaporaso
added a commit
to gregcaporaso/qiime
that referenced
this pull request
Mar 18, 2013
gregcaporaso
added a commit
to gregcaporaso/qiime
that referenced
this pull request
Mar 18, 2013
this is the second half of addressing biocore#711 (where the first half was completed in biocore#741)
gregcaporaso
added a commit
to gregcaporaso/qiime
that referenced
this pull request
Mar 18, 2013
need to make an udpate to qiime to use change from biocore#741.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the defaults as @gregcaporaso suggested so that if a depth is not passed it will use the deepest available. Updated the documentation in the script and library and added a test.