Transaction context improvement #1291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I started working transforming the code base to use transactions, I noticed that it was really hard to maintain a nice code. With the improvement in this PR to the Transaction context management, the code highly improves. It allows to enter multiple times in the context and only do something if we are leaving the last context.
Another change is the removal of the parameter
commit=False
. The execute function will never commit. Since the committing is automatically performed when exiting the context, you never want to explicitly commit, since through the code you don't know if there is something else in the transaction that shouldn't be committed...What the changes in here allows you to do is: