Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact summary add processing jobs #1706

Conversation

josenavas
Copy link
Contributor

Depends on #1705 so review/merge that one first.

This adds a list of jobs that use the given artifact as input, and shows their id, command name, status and current step

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 82.713% when pulling 50504b4 on josenavas:artifact-study-pages-show-procs into d8db841 on biocore:artifact-study-pages.

@josenavas
Copy link
Contributor Author

Ready for review

@ElDeveloper
Copy link
Member

👍 looks good!

@@ -54,6 +54,9 @@ def artifact_summary_get_request(user_id, artifact_id):
summary = artifact.html_summary_fp
job_info = None
errored_jobs = []
processing_jobs = [
[j.id, j.command.name, j.status, j.step] for j in artifact.jobs()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work? The braces are off.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean that the braces are off? It's a list comprehension generating a list of 4 elements, but filtering for those jobs that are part of an artifact transformation software. See this line for an example of the data generated here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 82.81% when pulling 22c5743 on josenavas:artifact-study-pages-show-procs into 898ffab on biocore:artifact-study-pages.

@antgonza antgonza merged commit b7aeaa1 into qiita-spots:artifact-study-pages Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants