-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artifact summary add processing jobs #1706
Artifact summary add processing jobs #1706
Conversation
… into artifact-study-pages-show-procs
Ready for review |
👍 looks good! |
@@ -54,6 +54,9 @@ def artifact_summary_get_request(user_id, artifact_id): | |||
summary = artifact.html_summary_fp | |||
job_info = None | |||
errored_jobs = [] | |||
processing_jobs = [ | |||
[j.id, j.command.name, j.status, j.step] for j in artifact.jobs() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work? The braces are off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean that the braces are off? It's a list comprehension generating a list of 4 elements, but filtering for those jobs that are part of an artifact transformation
software. See this line for an example of the data generated here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks.
Depends on #1705 so review/merge that one first.This adds a list of jobs that use the given artifact as input, and shows their id, command name, status and current step