Plugin installation #1909
Plugin installation #1909
Conversation
Plugin installation db
|
Note: tests here are failing because I changed the contents of the config file (added an entry). For fixing that I need to update the encoded config file for travis, but I'm not going to do that until this PR is ready to merge, so other PR can be done against master. |
| @@ -116,6 +116,8 @@ class ConfigurationManager(object): | |||
| The filepath to the portal styling config file | |||
| plugin_launcher : str | |||
| The script used to start the plugins | |||
| portal_dir : str | |||
There was a problem hiding this comment.
Shouldn't this be plugin_dir?
|
👍 just a few minor comments/questions. |
Addressing comments
|
|
||
| # Warning raised if No files will be allowed to be uploaded | ||
| # Warning raised if no cookie_secret | ||
| with warnings.catch_warnings(record=True) as warns: |
There was a problem hiding this comment.
Not really a comment - but some motivation on switching over to PY3
We can substitute this with assertWarns
There was a problem hiding this comment.
Does assertWarns allow you to check the contents of the warning? We have been using npt.assert_warns in other places of the code, but here I decided to use the catch warnings approach so I can test that the contents of the warnings is what I expect.
…-installation-parser
…into plugin-installation-parser
…s, as well as tests for those functions
…as fixing the create to take this into account
…ivate the needed plugins
Updating the phred_offset type to be choice
Allowing updating the oauth2 info
…into plugin-install-gui
Adding sleep while registering plugins
Branch that allows plugins to register themselves.
TODOs:
If you think that there is something missing in this TODO list, please add it. If you have a concern about this, please come and talk to me.
Fixes #1625