Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional fields to parameters. #10

Merged
merged 1 commit into from
Jun 19, 2018
Merged

Add additional fields to parameters. #10

merged 1 commit into from
Jun 19, 2018

Conversation

hscells
Copy link
Contributor

@hscells hscells commented Jun 18, 2018

This pull request is in reference to #9

I don't think anything else needs to be modified, since the number of requests can be changed through:

entrez.Limit = ncbi.NewLimiter(time.Second / 10)

I also added the field parameter, which is documented here:

https://www.ncbi.nlm.nih.gov/books/NBK25499/#chapter4.field

(note that this does not relate to the referenced issue, but something that others may find useful?)

Copy link
Member

@kortschak kortschak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures are unrelated.

@kortschak
Copy link
Member

Can you please send a PR to biogo/biogo adding yourself to A+C?

@hscells
Copy link
Contributor Author

hscells commented Jun 19, 2018

Thanks Dan, I have just sent the PR.

biogo/biogo#69

@kortschak kortschak merged commit bcc2595 into biogo:master Jun 19, 2018
@kortschak
Copy link
Member

Thank you for doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants